From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73A4E80AB1 for ; Wed, 27 Sep 2023 14:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbjI0O22 (ORCPT ); Wed, 27 Sep 2023 10:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbjI0O20 (ORCPT ); Wed, 27 Sep 2023 10:28:26 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00BB7F9; Wed, 27 Sep 2023 07:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=fY3tgArrYfp7UiQOV9ma8Q9n1cP+zTVSpeExNbzVza4=; b=yWJWqqYe2XRy/t2Old5oNg2JYA o3Qs9hrf5uhctU2jXuNEp3ML6UWPC81tXcCdm8pNcXfVq5oaLVVM4OMUKNtJCPpSXII8vrF1ri7dS lo2P68h3PhtoRkwxAcEMUG53r+NRbiL0nTvpdUVjue1ASo0GoRyXlnUb3AnuhnT3Uaus=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:34286 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qlVWV-0007Eq-Bw; Wed, 27 Sep 2023 10:28:19 -0400 Date: Wed, 27 Sep 2023 10:28:18 -0400 From: Hugo Villeneuve To: Rob Herring Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hvilleneuve@dimonoff.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Message-Id: <20230927102818.27b0beff6006392e91380ecd@hugovil.com> In-Reply-To: References: <20230920152015.1376838-1-hugo@hugovil.com> <20230920152015.1376838-4-hugo@hugovil.com> <20230921162424.GA435508-robh@kernel.org> <20230921123237.b3c50eb12746724a4fd62237@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2023 14:52:06 -0500 Rob Herring wrote: > On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve wrote: > > > > On Thu, 21 Sep 2023 11:24:24 -0500 > > Rob Herring wrote: > > > > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve > > > > > > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > > > > prefix. Add "nxp," prefix to comply with DT best practises. > > > > > > The opposite direction would be worth carrying in the driver, but I > > > don't think adding a vendor prefix is. I would just leave this as-is. > > > > > > Rob > > > > Hi Rob, > > I am not following you, can you clarify? > > Just keep the property as-is and don't add a 'nxp,' prefixed version. > It's not worth carrying the fallback in the driver. > > If you were dropping a vendor prefix from a property, then that's > worth it because there might be other users added. > > Rob Hi Rob, ok, then I will drop this patch as well as the other titled 'serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property' for V2. Hugo.