From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
ilpo.jarvinen@linux.intel.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, l.sanfilippo@kunbus.com,
lukas@wunner.de, p.rosenberger@kunbus.com
Subject: Re: [PATCH 6/6] serial: imx: do not set RS485 enabled if it is not supported
Date: Fri, 29 Sep 2023 08:39:42 +0200 [thread overview]
Message-ID: <20230929063942.qukemr4o7l5vdmud@pengutronix.de> (raw)
In-Reply-To: <20230928221246.13689-7-LinoSanfilippo@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
On Fri, Sep 29, 2023 at 12:12:46AM +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> If the imx driver cannot support RS485 it sets the UARTS rs485_supported
> structure to NULL. But it still calls uart_get_rs485_mode() which may set
> the RS485_ENABLED flag.
> The flag however is evaluated by the serial core in uart_configure_port()
I wonder if this is the code location where this problem should be
addressed. Or alternatively don't let uart_get_rs485_mode() set
RS485_ENABLED (and other flags) if rs485_supported doesn't suggest that
this works?
> [...]
>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
I don't know how picky Greg is here, but formally you missed to add an
S-o-b line for the sender of this patch (i.e. you with your gmx
address).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-29 6:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 22:12 [PATCH 0/6] Fixes and improvements for RS485 Lino Sanfilippo
2023-09-28 22:12 ` [PATCH 1/6] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2023-09-29 5:50 ` Greg KH
2023-09-29 12:21 ` Lino Sanfilippo
2023-09-28 22:12 ` [PATCH 2/6] serial: amba-pl011: get rid of useless wrapper pl011_get_rs485_mode() Lino Sanfilippo
2023-09-28 22:33 ` Lukas Wunner
2023-09-28 22:12 ` [PATCH 3/6] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2023-09-28 22:12 ` [PATCH 4/6] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2023-09-28 22:12 ` [PATCH 5/6] serial: core: make sure RS485 is cannot be enabled when it is not supported Lino Sanfilippo
2023-09-29 12:17 ` Hugo Villeneuve
2023-09-29 12:25 ` Lino Sanfilippo
2023-09-28 22:12 ` [PATCH 6/6] serial: imx: do not set RS485 enabled if " Lino Sanfilippo
2023-09-29 5:51 ` Greg KH
2023-09-29 12:22 ` Lino Sanfilippo
2023-09-29 6:39 ` Uwe Kleine-König [this message]
2023-09-29 13:46 ` Lino Sanfilippo
2023-09-29 15:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929063942.qukemr4o7l5vdmud@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.rosenberger@kunbus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®