From: Andrew Morton <akpm@linux-foundation.org>
To: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
Cc: shuah@kernel.org, hughd@google.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests:proc add missing field KSM in smaps_rollup[] array
Date: Sun, 1 Oct 2023 12:52:49 -0700 [thread overview]
Message-ID: <20231001125249.7c4fde44bf12ec7bd1ccf12a@linux-foundation.org> (raw)
In-Reply-To: <20230930122523.118173-1-swarupkotikalapudi@gmail.com>
On Sat, 30 Sep 2023 17:55:23 +0530 Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com> wrote:
> Missing field KSM is added in g_smaps_rollup[] array as it
> fixes assert in function test_proc_pid_smaps_rollup()
>
> Without this patchset test fails for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ...
> selftests: proc: proc-empty-vm
> proc-empty-vm: proc-empty-vm.c:299: test_proc_pid_smaps_rollup:
> Assertion `rv == sizeof(g_smaps_rollup) - 1' failed.
> /usr/bin/timeout: the monitored command dumped core
> Aborted
> not ok 5 selftests: proc: proc-empty-vm # exit=134
> ...
>
> With this patchset test passes for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ....
> timeout set to 45
> selftests: proc: proc-empty-vm
> ok 5 selftests: proc: proc-empty-vm
> ....
>
Thanks. We fixed this in
commit 9d1be94df5acd486b157e85ffa53d344e5b17e22
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Thu Sep 7 14:10:12 2023 +0300
selftests/proc: fixup proc-empty-vm test after KSM changes
prev parent reply other threads:[~2023-10-01 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 12:25 Swarup Laxman Kotiaklapudi
2023-10-01 19:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231001125249.7c4fde44bf12ec7bd1ccf12a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®