mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Köry Maincent" <kory.maincent@bootlin.com>
To: Cai Huoqing <cai.huoqing@linux.dev>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Serge Semin <fancer.lancer@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Kory Maincent <kory.maincent@bootlin.com>
Subject: [PATCH v2 1/5] dmaengine: dw-edma: Fix the ch_count hdma callback
Date: Mon,  2 Oct 2023 15:17:45 +0200	[thread overview]
Message-ID: <20231002131749.2977952-2-kory.maincent@bootlin.com> (raw)
In-Reply-To: <20231002131749.2977952-1-kory.maincent@bootlin.com>

From: Kory Maincent <kory.maincent@bootlin.com>

The current check of ch_en enabled to know the maximum number of available
hardware channels is wrong as it check the number of ch_en register set
but all of them are unset at probe. This register is set at the
dw_hdma_v0_core_start function which is run lately before a DMA transfer.

The HDMA IP have no way to know the number of hardware channels available
like the eDMA IP, then let set it to maximum channels and let the platform
set the right number of channels.

Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

See the following thread mail that talk about this issue:
https://lore.kernel.org/lkml/20230607095832.6d6b1a73@kmaincent-XPS-13-7390/

Changes in v2:
- Add comment
---
 drivers/dma/dw-edma/dw-hdma-v0-core.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 00b735a0202a..3e78d4fd3955 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -65,18 +65,11 @@ static void dw_hdma_v0_core_off(struct dw_edma *dw)
 
 static u16 dw_hdma_v0_core_ch_count(struct dw_edma *dw, enum dw_edma_dir dir)
 {
-	u32 num_ch = 0;
-	int id;
-
-	for (id = 0; id < HDMA_V0_MAX_NR_CH; id++) {
-		if (GET_CH_32(dw, id, dir, ch_en) & BIT(0))
-			num_ch++;
-	}
-
-	if (num_ch > HDMA_V0_MAX_NR_CH)
-		num_ch = HDMA_V0_MAX_NR_CH;
-
-	return (u16)num_ch;
+	/* The HDMA IP have no way to know the number of hardware channels
+	 * available, we set it to maximum channels and let the platform
+	 * set the right number of channels.
+	 */
+	return HDMA_V0_MAX_NR_CH;
 }
 
 static enum dma_status dw_hdma_v0_core_ch_status(struct dw_edma_chan *chan)
-- 
2.25.1


  reply	other threads:[~2023-10-02 13:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 13:17 [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP in remote setup Köry Maincent
2023-10-02 13:17 ` Köry Maincent [this message]
2023-10-03 11:23   ` [PATCH v2 1/5] dmaengine: dw-edma: Fix the ch_count hdma callback Serge Semin
2023-10-10 14:56   ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes Köry Maincent
2023-10-10 14:59   ` Manivannan Sadhasivam
2023-10-11  7:23     ` Köry Maincent
2023-10-11 10:38       ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 3/5] dmaengine: dw-edma: Add HDMA remote interrupt configuration Köry Maincent
2023-10-10 15:00   ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 4/5] dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup Köry Maincent
2023-10-03 11:48   ` Serge Semin
2023-10-03 12:15     ` Köry Maincent
2023-10-03 15:20       ` Serge Semin
2023-10-03 15:34         ` Köry Maincent
2023-10-03 15:57           ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 5/5] dmaengine: dw-edma: eDMA: " Köry Maincent
2023-10-03 11:59   ` Serge Semin
2023-10-03 12:17     ` Köry Maincent
2023-10-04  7:21 ` [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP " Vinod Koul
2023-10-04  8:04   ` Köry Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231002131749.2977952-2-kory.maincent@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=Gustavo.Pimentel@synopsys.com \
    --cc=cai.huoqing@linux.dev \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=herve.codina@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®