From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org,
Michael Jeanson <mjeanson@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
bpf@vger.kernel.org, Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [RFC PATCH v3 1/5] tracing: Introduce faultable tracepoints (v3)
Date: Mon, 2 Oct 2023 19:10:23 -0400 [thread overview]
Message-ID: <20231002191023.6175294d@gandalf.local.home> (raw)
In-Reply-To: <20231002202531.3160-2-mathieu.desnoyers@efficios.com>
On Mon, 2 Oct 2023 16:25:27 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> @@ -202,8 +198,12 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
> if (WARN_ON_ONCE(RCUIDLE_COND(rcuidle))) \
> return; \
> \
> - /* keep srcu and sched-rcu usage consistent */ \
> - preempt_disable_notrace(); \
> + if (mayfault) { \
> + rcu_read_lock_trace(); \
I thought rcu_trace was for the case that a task can not voluntarily call
schedule. If this tracepoint tries to read user space memory that isn't
paged in, and faults, can't the faulting logic call schedule and break this
requirement?
-- Steve
> + } else { \
> + /* keep srcu and sched-rcu usage consistent */ \
> + preempt_disable_notrace(); \
> + } \
> \
> /* \
> * For rcuidle callers, use srcu since sched-rcu \
next prev parent reply other threads:[~2023-10-02 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 20:25 [RFC PATCH v3 0/5] Faultable Tracepoints Mathieu Desnoyers
2023-10-02 20:25 ` [RFC PATCH v3 1/5] tracing: Introduce faultable tracepoints (v3) Mathieu Desnoyers
2023-10-02 23:10 ` Steven Rostedt [this message]
2023-10-03 0:14 ` Paul E. McKenney
2023-10-03 1:19 ` Steven Rostedt
2023-10-03 13:44 ` Paul E. McKenney
2023-10-03 14:08 ` Steven Rostedt
2023-10-03 17:33 ` Paul E. McKenney
2023-10-03 17:37 ` Mathieu Desnoyers
2023-10-03 17:38 ` Steven Rostedt
2023-10-03 18:15 ` Paul E. McKenney
2023-10-02 20:25 ` [RFC PATCH v3 2/5] tracing/ftrace: Add support for faultable tracepoints Mathieu Desnoyers
2023-10-02 20:25 ` [RFC PATCH v3 3/5] tracing/bpf-trace: add " Mathieu Desnoyers
2023-10-02 20:25 ` [RFC PATCH v3 4/5] tracing/perf: " Mathieu Desnoyers
2023-10-02 20:25 ` [RFC PATCH v3 5/5] tracing: convert sys_enter/exit to " Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002191023.6175294d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=joel@joelfernandes.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=mjeanson@efficios.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®