From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B82E8FDB0 for ; Tue, 3 Oct 2023 19:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjJCT5L (ORCPT ); Tue, 3 Oct 2023 15:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230390AbjJCT5K (ORCPT ); Tue, 3 Oct 2023 15:57:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEB60A1 for ; Tue, 3 Oct 2023 12:57:06 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 381E8C433C8; Tue, 3 Oct 2023 19:57:05 +0000 (UTC) Date: Tue, 3 Oct 2023 15:58:10 -0400 From: Steven Rostedt To: jim.cromie@gmail.com Cc: =?UTF-8?B?xYF1a2Fzeg==?= Bartosik , Jason Baron , Andrew Morton , Kees Cook , Douglas Anderson , Guenter Roeck , Yaniv Tzoreff , Benson Leung , linux-kernel@vger.kernel.org, upstream@semihalf.com, Vincent Whitchurch Subject: Re: [PATCH v1] dynamic_debug: add support for logs destination Message-ID: <20231003155810.6df9de16@gandalf.local.home> In-Reply-To: References: <20230915154856.1896062-1-lb@semihalf.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Oct 2023 14:49:20 -0600 jim.cromie@gmail.com wrote: > hi Lukasz, > > sorry my kernel-time has been in my own trees. > > What I dont understand is why +T is insufficient. > > IIUC, tracefs is intended for production use. > thats why each event can be enabled / disabled > - to select and minimize whats traced, and not impact the system > > and +T can forward all pr_debugs to trace, > (by 1-few trace events defined similarly to others) > or very few, giving yet another selection mechanism > to choose or eliminate specific pr-debugs and reduce traffic to > interesting stuff. > > Once your debug is in the trace-buf, > shouldnt user-space be deciding what to do with it ? > a smart daemon could leverage tracefs to good effect. > > IMO the main value of +T is that it allows feeding existing pr_debugs > into the place where other trace-data is already integrated and managed. > > At this point, I dont see any extra destination handling as prudent. > I'm fine with either approach. I kind of like the creation of the instance, as that allows the user to keep this debug separate from other tracing going on. We are starting to have multiple applications using the tracing buffer (although most are using instances, which is why I'm trying to make them lighter weight with the eventfs code). -- Steve