On Tue, 3 Oct 2023 06:42:13 -0700 Jakub Kicinski wrote: > On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > > I've just noticed that there is a WARNING: > > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ > > > > but then on the newest kernel checkpatch.pl is silent: > > ./scripts/checkpatch.pl > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch > > total: 0 errors, 0 warnings, 0 checks, 277 lines checked > > > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has > > no obvious style problems and is ready for submission. > > > > Does the checkpatch for patchwork differs in any way from mainline? > > > > We run: > > checkpatch with --strict --max-line-length=80 > > https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh > > The "multiple new lines" warning on patch 2 looks legit, no? Indeed - the: '--strict --max-line-length=80' makes the difference... If I may ask - why it is added? Or to ask in other way - why the "vanila" checkpatch is not enough for net-dev ? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de