From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0EBE8FDBF for ; Wed, 4 Oct 2023 01:02:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237344AbjJDBCI (ORCPT ); Tue, 3 Oct 2023 21:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjJDBCH (ORCPT ); Tue, 3 Oct 2023 21:02:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B443A9 for ; Tue, 3 Oct 2023 18:02:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38633C433C8; Wed, 4 Oct 2023 01:02:03 +0000 (UTC) Date: Tue, 3 Oct 2023 21:03:09 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] tracing/timerlat: Hotplug support for the user-space interface Message-ID: <20231003210309.4335307d@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Sep 2023 17:02:46 +0200 Daniel Bristot de Oliveira wrote: > The osnoise/per_cpu/CPU$/timerlat_fd is create for each possible > CPU, but it might create confusion if the CPU is not online. > > Create the file only for online CPUs, also follow hotplug by > creating and deleting as CPUs come and go. > > Fixes: e88ed227f639 ("tracing/timerlat: Add user-space interface") Is this a fix that needs to go in now and Cc'd to stable? Or is this something that can wait till the next merge window? -- Steve > Signed-off-by: Daniel Bristot de Oliveira > --- > > Changes from V2: > - Better split the code into the generic (per_cpu/cpu$) > and timerlat (/timerlat_fd) specific function (Daniel) > - Fixed a cpus_read_lock/unlock() usage (kbuild test) > Link: https://lore.kernel.org/lkml/6b9a5f306e488bc77bf8521faeade420a0adf3e4.1695224204.git.bristot@kernel.org/ > > Changes from V1: > - Fix compilation issue when !HOTPLUG > - Fix init interface | hotplug race > Link: https://lore.kernel.org/lkml/b619d9fd08a3bb47018cf40afa95783844a3c1fd.1694789910.git.bristot@kernel.org/ > > kernel/trace/trace_osnoise.c | 149 ++++++++++++++++++++++++++++------- > 1 file changed, 121 insertions(+), 28 deletions(-) > >