From: Arvind Yadav <Arvind.Yadav@amd.com>
To: <Christian.Koenig@amd.com>, <alexander.deucher@amd.com>,
<shashank.sharma@amd.com>, <Felix.Kuehling@amd.com>,
<Mukul.Joshi@amd.com>, <Xinhui.Pan@amd.com>, <airlied@gmail.com>,
<daniel@ffwll.ch>
Cc: <amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Arvind Yadav <Arvind.Yadav@amd.com>
Subject: [PATCH v3 0/2] drm/amdkfd: Fix unaligned doorbell absolute offset for gfx8
Date: Wed, 4 Oct 2023 21:46:50 +0530 [thread overview]
Message-ID: <20231004161652.3082-1-Arvind.Yadav@amd.com> (raw)
On older chips, the absolute doorbell offset within
the doorbell page is based on the queue ID.
KFD is using queue ID and doorbell size to get an
absolute doorbell offset in userspace.
Here, adding db_size in byte to find the doorbell's
absolute offset for both 32-bit and 64-bit doorbell sizes.
So that doorbell offset will be aligned based on the doorbell
size.
v2:
- Addressed the review comment from Felix.
v3:
- Adding doorbell_size as parameter to get db absolute offset.
Arvind Yadav (2):
drm/amdgpu: Adding db_size to get doorbell absolute offset
drm/amdkfd: get doorbell's absolute offset based on the db size
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 5 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 13 +++++++++----
.../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 6 +++++-
drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 13 +++++++++++--
.../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 4 +++-
5 files changed, 31 insertions(+), 10 deletions(-)
--
2.34.1
next reply other threads:[~2023-10-04 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 16:16 Arvind Yadav [this message]
2023-10-04 16:16 ` [PATCH v3 1/2] drm/amdgpu: Adding db_size to get doorbell absolute offset Arvind Yadav
2023-10-04 16:16 ` [PATCH v3 2/2] drm/amdkfd: get doorbell's absolute offset based on the db size Arvind Yadav
2023-10-04 16:59 ` Felix Kuehling
2023-10-04 17:17 ` Yadav, Arvind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004161652.3082-1-Arvind.Yadav@amd.com \
--to=arvind.yadav@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Mukul.Joshi@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shashank.sharma@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®