From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A2BE92FF3 for ; Fri, 6 Oct 2023 07:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjJFHX3 (ORCPT ); Fri, 6 Oct 2023 03:23:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbjJFHX2 (ORCPT ); Fri, 6 Oct 2023 03:23:28 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090D4CA; Fri, 6 Oct 2023 00:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696577008; x=1728113008; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mWHcdTvH6aYA57g0fq1YlCnr+8VV/+w6xGLIONT5Tg4=; b=XvjOfVheXSvgMl9pQMz2L7czktDkrmcXvQo1QYHGB7MOaqdOMKMO+OS5 SbDbmu4atELcLQOYbXYCn56Hi+KP89D7nYetBlBogl2BOmiljIdVAA6x6 wCVx2gbPMyagqRhWbVODsA4rx90VW7FZwEanZT5HZYus8AOhSQiggA1FB 5KTNjemrFvBZ/nnp/81BTpdtgPsswlJMgJZusMCKlfpUUQ8WjLiylBjqH VFhLIbYiT4XtBBki8lBERDz/6MWNuXqOBRIGwsB4JwW9Y+UKIT3Ywq6+5 u9fQvoyGkW6lEchXnHrlYewyqISelNgRPr3Xv0+GvvO9O385XIsbR7y9w Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="374046251" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="374046251" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 00:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="781543497" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="781543497" Received: from pglc0394.png.intel.com ([10.221.87.72]) by orsmga008.jf.intel.com with ESMTP; 06 Oct 2023 00:23:22 -0700 From: Rohan G Thomas To: kuba@kernel.org Cc: alexandre.torgue@foss.st.com, andriy.shevchenko@linux.intel.com, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, fancer.lancer@gmail.com, joabreu@synopsys.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com, rohan.g.thomas@intel.com Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling Date: Fri, 6 Oct 2023 15:23:19 +0800 Message-Id: <20231006072319.22441-1-rohan.g.thomas@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231005070538.0826bf9d@kernel.org> References: <20231005070538.0826bf9d@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Oct 2023 07:05:38 -0700 Jakub Kicinski wrote: > On Thu, 5 Oct 2023 20:14:41 +0800 Rohan G Thomas wrote: > > > So the question now is whether we want Rohan to do this conversion > > > _first_, in DW QoS 5, and then add xgmac part. Or the patch should > > > go in as is and you'll follow up with the conversion? > > > > If agreed, this commit can go in. I can submit another patch with the > > refactoring suggested by Serge. > > Did you miss the emphasis I put on the word "first" in my reply? > Cleanup first, nobody will be keeping track whether your fulfilled your > promises or not :| Hi Jakub, Agreed. I'll do the cleanup first. Best Regards, Rohan