mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Kanner <andrew.kanner@gmail.com>
To: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Andrew Kanner <andrew.kanner@gmail.com>
Subject: [PATCH RESEND trivial v2] checkpatch: stop complaining about tags suggested/tested by syzkaller
Date: Fri,  6 Oct 2023 18:55:02 +0300	[thread overview]
Message-ID: <20231006155501.3120-1-andrew.kanner@gmail.com> (raw)

If you submit a testing request to syzkaller it may reply with:
> syzbot has tested the proposed patch and the reproducer did not \
> trigger any issue:
>
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@syzkaller.appspotmail.com

Checkpatch is ok with Reported-by tags, but complains about
Reported-and-tested-by tags:
> WARNING: Possible unwrapped commit description (prefer a maximum 75 \
> chars per line)
> #48:
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@syzkaller.appspotmail.com

Adding the new tag to signature_tags removes this warning.

Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
---
PS: It's expected that checkpatch.pl will complain about this patch for
checkpatch.pl, although I tried to remove some warnings - see below.

v2:
  - suppress 4 warnings from checkpatch.pl, adding '>' to commit-msg
  - ./scripts/checkpatch.pl is still complaining about this patch
    (mostly about the keywords in diff):
      total: 6 errors, 14 warnings
    although it's not complaining too much about commit-msg (only about
    Reported-and-tested-by tag)
v1: https://lore.kernel.org/all/20230829123446.3455193-1-andrew.kanner@gmail.com/

 scripts/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7d16f863edf1..a9dbc9c6e26c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -617,6 +617,7 @@ our $signature_tags = qr{(?xi:
 	Tested-by:|
 	Reviewed-by:|
 	Reported-by:|
+	Reported-and-tested-by:|
 	Suggested-by:|
 	To:|
 	Cc:
@@ -711,7 +712,7 @@ sub find_standard_signature {
 	my ($sign_off) = @_;
 	my @standard_signature_tags = (
 		'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
-		'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
+		'Reviewed-by:', 'Reported-by:', 'Reported-and-tested-by:', 'Suggested-by:'
 	);
 	foreach my $signature (@standard_signature_tags) {
 		return $signature if (get_edit_distance($sign_off, $signature) <= 2);
-- 
2.39.3


                 reply	other threads:[~2023-10-06 15:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006155501.3120-1-andrew.kanner@gmail.com \
    --to=andrew.kanner@gmail.com \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®