mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: <lee@kernel.org>, <pavel@ucw.cz>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<andy.shevchenko@gmail.com>
Cc: <kernel@sberdevices.ru>, <rockosov@gmail.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-leds@vger.kernel.org>,
	George Stark <gnstark@salutedevices.com>,
	Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: [PATCH v1 05/11] leds: aw200xx: calculate dts property display_rows in driver
Date: Fri, 6 Oct 2023 19:04:31 +0300	[thread overview]
Message-ID: <20231006160437.15627-6-ddrokosov@salutedevices.com> (raw)
In-Reply-To: <20231006160437.15627-1-ddrokosov@salutedevices.com>

From: George Stark <gnstark@salutedevices.com>

Get rid of device tree property "awinic,display-rows" and calculate it
in driver using led definition nodes. display-row actually means number
of current switches and depends on how leds are connected to the device.

Signed-off-by: George Stark <gnstark@salutedevices.com>
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
---
 drivers/leds/leds-aw200xx.c | 40 ++++++++++++++++++++++++++-----------
 1 file changed, 28 insertions(+), 12 deletions(-)

diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c
index d92c082d4ab3..5b6907eb6299 100644
--- a/drivers/leds/leds-aw200xx.c
+++ b/drivers/leds/leds-aw200xx.c
@@ -383,6 +383,32 @@ static void aw200xx_disable(const struct aw200xx *const chip)
 		gpio_set_value(chip->hwen, 0);
 }
 
+static int aw200xx_probe_get_display_rows(struct device *dev, struct aw200xx *chip)
+{
+	struct fwnode_handle *child;
+	u32 max_source = 0;
+
+	device_for_each_child_node(dev, child) {
+		u32 source;
+		int ret;
+
+		ret = fwnode_property_read_u32(child, "reg", &source);
+		if (ret || source >= chip->cdef->channels)
+			continue;
+
+		if (max_source < source)
+			max_source = source;
+	}
+
+	chip->display_rows = max_source / chip->cdef->display_size_columns + 1;
+	if (!chip->display_rows) {
+		dev_err(dev, "No valid led definitions found\n");
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
 static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip)
 {
 	struct fwnode_handle *child;
@@ -390,18 +416,8 @@ static int aw200xx_probe_fw(struct device *dev, struct aw200xx *chip)
 	int ret;
 	int i;
 
-	ret = device_property_read_u32(dev, "awinic,display-rows",
-				       &chip->display_rows);
-	if (ret)
-		return dev_err_probe(dev, ret,
-				     "Failed to read 'display-rows' property\n");
-
-	if (!chip->display_rows ||
-	    chip->display_rows > chip->cdef->display_size_rows_max) {
-		return dev_err_probe(dev, ret,
-				     "Invalid leds display size %u\n",
-				     chip->display_rows);
-	}
+	if (aw200xx_probe_get_display_rows(dev, chip))
+		return -EINVAL;
 
 	current_max = aw200xx_imax_from_global(chip, AW200XX_IMAX_MAX_uA);
 	current_min = aw200xx_imax_from_global(chip, AW200XX_IMAX_MIN_uA);
-- 
2.36.0


  parent reply	other threads:[~2023-10-06 16:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 16:04 [PATCH v1 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 02/11] dt-bindings: leds: aw200xx: fix led dt node pattern Dmitry Rokosov
2023-10-10 14:11   ` Rob Herring
2023-10-06 16:04 ` [PATCH v1 03/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-10-06 17:57   ` Andy Shevchenko
2023-10-09 13:09     ` Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 04/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpio property Dmitry Rokosov
2023-10-10 14:13   ` Rob Herring
2023-10-10 14:57     ` Dmitry Rokosov
2023-10-06 16:04 ` Dmitry Rokosov [this message]
2023-10-06 17:59   ` [PATCH v1 05/11] leds: aw200xx: calculate dts property display_rows in driver Andy Shevchenko
2023-10-09 13:20     ` Dmitry Rokosov
2023-10-16 23:30       ` George Stark
2023-10-06 16:04 ` [PATCH v1 06/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-10-10 14:15   ` Rob Herring
2023-10-06 16:04 ` [PATCH v1 07/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-10-06 18:01   ` Andy Shevchenko
2023-10-09 13:14     ` Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 08/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 09/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-10-06 18:03   ` Andy Shevchenko
2023-10-09 13:18     ` Dmitry Rokosov
2023-10-09 14:02       ` Dmitry Rokosov
2023-10-16 21:22         ` George Stark
2023-10-06 16:04 ` [PATCH v1 10/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 11/11] dt-bindings: leds: Add binding for AW20108 led driver Dmitry Rokosov
2023-10-10 14:17   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006160437.15627-6-ddrokosov@salutedevices.com \
    --to=ddrokosov@salutedevices.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gnstark@salutedevices.com \
    --cc=kernel@sberdevices.ru \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®