From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7363BE94108 for ; Fri, 6 Oct 2023 19:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233258AbjJFT0E (ORCPT ); Fri, 6 Oct 2023 15:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233013AbjJFT0C (ORCPT ); Fri, 6 Oct 2023 15:26:02 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67934A2; Fri, 6 Oct 2023 12:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g8R3qBu9m/zPeVFFMHKdKfTDFnYyK8HF/dF9rq+sKnE=; b=PSngGpGo4hR9epceZ+3PeAIDlm euGOSftofJ2bZvRttvA8lrev0oTtCSrbZ2tuR2QWOSfVbPXzxImPxvjMe3DnunRwTKSANsu2hqpyo ZVSHHWjg0ND+ZYprsmtyEdOjoTOvcLXTmkROCWznP6hXsZBUp0TEDMWA6XqR9nENqN7AGLar7mrkN OR7uhfWsf97N3cOhhwbHHhUfFjd1Y0erek1lgzwUTg9v5aV0YyPQbKRYMZmuI5iClN4MPuS+dtpAo 133Y7mpFZ/2s/VKQVq5EGwj/GILyPE1JOevlgWThziUaYqIKaXYXtuUeGuqBPqE2/JFm1C9qgR2Bj eYNNKOVA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qoqRI-00Cq4H-1m; Fri, 06 Oct 2023 19:24:46 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id A20F7300392; Fri, 6 Oct 2023 21:24:45 +0200 (CEST) Date: Fri, 6 Oct 2023 21:24:45 +0200 From: Peter Zijlstra To: Mike Galbraith Cc: Marek Szyprowski , Biju Das , "bsegall@google.com" , "bristot@redhat.com" , "chris.hyser@oracle.com" , "corbet@lwn.net" , "dietmar.eggemann@arm.com" , "gregkh@linuxfoundation.org" , "joel@joelfernandes.org" , "joshdon@google.com" , "juri.lelli@redhat.com" , "kprateek.nayak@amd.com" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "patrick.bellasi@matbug.net" , Pavel Machek , "pjt@google.com" , "qperret@google.com" , "qyousef@layalina.io" , "rostedt@goodmis.org" , "tglx@linutronix.de" , "tim.c.chen@linux.intel.com" , "timj@gnu.org" , "vincent.guittot@linaro.org" , "youssefesmat@chromium.org" , "yu.c.chen@intel.com" , "mgorman@suse.de" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH] sched/fair: fix pick_eevdf to always find the correct se Message-ID: <20231006192445.GE743@noisy.programming.kicks-ass.net> References: <20231005150258.GA36277@noisy.programming.kicks-ass.net> <553e2ee4-ab3a-4635-a74f-0ba4cc03f3f9@samsung.com> <867f5121d7d010cacf938c293f862b0cea560ec2.camel@gmx.de> <20231006140042.GG36277@noisy.programming.kicks-ass.net> <20231006155501.GH36277@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006155501.GH36277@noisy.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2023 at 05:55:01PM +0200, Peter Zijlstra wrote: > And yeah, min_deadline is hosed somehow. > > migration/28-185 [028] d..2. 70.264274: validate_cfs_rq: --- / > migration/28-185 [028] d..2. 70.264277: __print_se: ffff88845cf48080 w: 1024 ve: -58857638 lag: 870381 vd: -55861854 vmd: -66302085 E (11372/tr) > migration/28-185 [028] d..2. 70.264280: __print_se: ffff88810d165800 w: 25 ve: -80323686 lag: 22336429 vd: -41496434 vmd: -66302085 E (-1//autogroup-31) > migration/28-185 [028] d..2. 70.264282: __print_se: ffff888108379000 w: 25 ve: 0 lag: -57987257 vd: 114632828 vmd: 114632828 N (-1//autogroup-33) > migration/28-185 [028] d..2. 70.264283: validate_cfs_rq: min_deadline: -55861854 avg_vruntime: -62278313462 / 1074 = -57987256 > > I need to go make dinner (kids hungry), but I'll see if I can figure out > how this happens... *sigh*, does the below help? --- diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 04fbcbda97d5..6a670f119efa 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3632,6 +3747,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, */ deadline = div_s64(deadline * old_weight, weight); se->deadline = se->vruntime + deadline; + min_deadline_cb_propagate(&se->run_node, NULL); } #ifdef CONFIG_SMP