From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A97E95A62 for ; Sat, 7 Oct 2023 10:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343841AbjJGKgx (ORCPT ); Sat, 7 Oct 2023 06:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343815AbjJGKgs (ORCPT ); Sat, 7 Oct 2023 06:36:48 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EEB779E; Sat, 7 Oct 2023 03:36:46 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 397AaKv9023928; Sat, 7 Oct 2023 12:36:20 +0200 Date: Sat, 7 Oct 2023 12:36:20 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , Zhangjin Wu , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] tools/nolibc: drop test for getauxval(AT_PAGESZ) Message-ID: <20231007103620.GB23812@1wt.eu> References: <20231007-nolibc-auxval-pagesz-v1-1-af00804edead@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231007-nolibc-auxval-pagesz-v1-1-af00804edead@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 07, 2023 at 12:18:55PM +0200, Thomas Weißschuh wrote: > The test will not work for systems with pagesize != 4096 like aarch64 > and some others. > > Other testcases are already testing the same functionality: > * auxv_AT_UID tests getauxval() in general. > * test_getpagesize() tests pagesize() which directly calls > getauxval(AT_PAGESZ). > > Fixes: 48967b73f8fe ("selftests/nolibc: add testcases for startup code") > Cc: stable@vger.kernel.org > Signed-off-by: Thomas Weißschuh > --- > Note: > > This should probably also make it into 6.6. Agreed, you should just push it to the fixes branch. Thanks! Willy