From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421CBE95A63 for ; Sat, 7 Oct 2023 16:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344054AbjJGQGR (ORCPT ); Sat, 7 Oct 2023 12:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344023AbjJGQGP (ORCPT ); Sat, 7 Oct 2023 12:06:15 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C257FB9; Sat, 7 Oct 2023 09:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696694773; x=1728230773; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n5AFnPXEzN+QKzdl9114Nc4MT/H4AlQFbFyb9f0tsJE=; b=IKLN4L94kWQMYIE+DJRjPfVcVm/l2fUX3Wh71EeD5dcKJipJ1mzOSB/K cuLY/Qslb4Bjw5Teu99r1GMz08DnOKo1LEPE6lesxx/01C/q598hN/mZl 3r+7XSC2Pq+5YW4ysy8Ol2IySB1hH3JdgWpAgErK+CkP8Ty80flMXT+6p 4kj8zOJB3Z7WcTsdl1YrfzXnJEC4O81yLgQijvx/9uJgQAfD/T2Ty0jXx 6bHHbcsYSR8VMRVrVYdLnjherN/qE5Z1WPlXmUXqIjVc3W1kcinfjKN8b tqH6YldVdaRqpGeMZt1Yd3KvM3vZy5wQdfDrk/XdM4bSyVOK8kUYEwcHV w==; X-IronPort-AV: E=McAfee;i="6600,9927,10856"; a="387806740" X-IronPort-AV: E=Sophos;i="6.03,206,1694761200"; d="scan'208";a="387806740" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2023 09:06:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10856"; a="702413998" X-IronPort-AV: E=Sophos;i="6.03,206,1694761200"; d="scan'208";a="702413998" Received: from lkp-server01.sh.intel.com (HELO 8a3a91ad4240) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 07 Oct 2023 09:06:10 -0700 Received: from kbuild by 8a3a91ad4240 with local (Exim 4.96) (envelope-from ) id 1qp9oe-0004XN-0m; Sat, 07 Oct 2023 16:06:08 +0000 Date: Sun, 8 Oct 2023 00:05:40 +0800 From: kernel test robot To: Chuyi Zhou , bpf@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, tj@kernel.org, linux-kernel@vger.kernel.org, Chuyi Zhou Subject: Re: [PATCH bpf-next v4 4/8] bpf: Introduce css open-coded iterator kfuncs Message-ID: <202310072337.CzRlbffm-lkp@intel.com> References: <20231007124522.34834-5-zhouchuyi@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007124522.34834-5-zhouchuyi@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chuyi, kernel test robot noticed the following build warnings: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Chuyi-Zhou/cgroup-Prepare-for-using-css_task_iter_-in-BPF/20231007-204750 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20231007124522.34834-5-zhouchuyi%40bytedance.com patch subject: [PATCH bpf-next v4 4/8] bpf: Introduce css open-coded iterator kfuncs config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231007/202310072337.CzRlbffm-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231007/202310072337.CzRlbffm-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310072337.CzRlbffm-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/bpf/cgroup_iter.c:308:17: warning: no previous prototype for 'bpf_iter_css_new' [-Wmissing-prototypes] 308 | __bpf_kfunc int bpf_iter_css_new(struct bpf_iter_css *it, | ^~~~~~~~~~~~~~~~ >> kernel/bpf/cgroup_iter.c:332:41: warning: no previous prototype for 'bpf_iter_css_next' [-Wmissing-prototypes] 332 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_next(struct bpf_iter_css *it) | ^~~~~~~~~~~~~~~~~ >> kernel/bpf/cgroup_iter.c:353:18: warning: no previous prototype for 'bpf_iter_css_destroy' [-Wmissing-prototypes] 353 | __bpf_kfunc void bpf_iter_css_destroy(struct bpf_iter_css *it) | ^~~~~~~~~~~~~~~~~~~~ In file included from : kernel/bpf/cgroup_iter.c: In function 'bpf_iter_css_new': include/linux/compiler_types.h:425:45: error: call to '__compiletime_assert_320' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css) 425 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:406:25: note: in definition of macro '__compiletime_assert' 406 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:425:9: note: in expansion of macro '_compiletime_assert' 425 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ kernel/bpf/cgroup_iter.c:313:9: note: in expansion of macro 'BUILD_BUG_ON' 313 | BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css)); | ^~~~~~~~~~~~ vim +/bpf_iter_css_new +308 kernel/bpf/cgroup_iter.c 307 > 308 __bpf_kfunc int bpf_iter_css_new(struct bpf_iter_css *it, 309 struct cgroup_subsys_state *start, unsigned int flags) 310 { 311 struct bpf_iter_css_kern *kit = (void *)it; 312 313 BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css)); 314 BUILD_BUG_ON(__alignof__(struct bpf_iter_css_kern) != __alignof__(struct bpf_iter_css)); 315 316 kit->start = NULL; 317 switch (flags) { 318 case BPF_CGROUP_ITER_DESCENDANTS_PRE: 319 case BPF_CGROUP_ITER_DESCENDANTS_POST: 320 case BPF_CGROUP_ITER_ANCESTORS_UP: 321 break; 322 default: 323 return -EINVAL; 324 } 325 326 kit->start = start; 327 kit->pos = NULL; 328 kit->flags = flags; 329 return 0; 330 } 331 > 332 __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_next(struct bpf_iter_css *it) 333 { 334 struct bpf_iter_css_kern *kit = (void *)it; 335 336 if (!kit->start) 337 return NULL; 338 339 switch (kit->flags) { 340 case BPF_CGROUP_ITER_DESCENDANTS_PRE: 341 kit->pos = css_next_descendant_pre(kit->pos, kit->start); 342 break; 343 case BPF_CGROUP_ITER_DESCENDANTS_POST: 344 kit->pos = css_next_descendant_post(kit->pos, kit->start); 345 break; 346 case BPF_CGROUP_ITER_ANCESTORS_UP: 347 kit->pos = kit->pos ? kit->pos->parent : kit->start; 348 } 349 350 return kit->pos; 351 } 352 > 353 __bpf_kfunc void bpf_iter_css_destroy(struct bpf_iter_css *it) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki