From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E16E95A87 for ; Sun, 8 Oct 2023 00:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344249AbjJHAxw (ORCPT ); Sat, 7 Oct 2023 20:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234474AbjJHAxZ (ORCPT ); Sat, 7 Oct 2023 20:53:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD7A330D2; Sat, 7 Oct 2023 17:51:52 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C91DBC43215; Sun, 8 Oct 2023 00:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696726246; bh=pFXi+Khxzj9U516zTbG3gItYbGtioUkBqrakjfixPy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qix950EQpzzm3lRuFrDSi5rdawlZ2LYKcZlkRdDex5t8HlO7s47bArpEffXA+1FCA aKg7MB1Qt+miLNG5L7IQ7XnsTYmTh22SiQuVQONYM0n6O3x3AFKqyYigNHhZgPyscu BtW+iLFrUC/wz30GtFDdz56qbh4QfXfp5rBvNbYCOmOdlFDD4l+WEUcKH3y3yXu/DV slqJqHfC2gPjeK12rT+NZNwMGIefgHKTUbI5dEugn/r6cehRSTVVMloLOGjeDeBoX0 tz89gsZhQF2fdFtZ4ZXy8GrMYatE1ombAQqk2PjR7Kk3N0hsIkoQENZMEM0Xb6P94P PQkwNKTfFB0xQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Heiner Kallweit , Peter Rosin , Wolfram Sang , Sasha Levin , linux-i2c@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 4/8] i2c: mux: Avoid potential false error message in i2c_mux_add_adapter Date: Sat, 7 Oct 2023 20:50:34 -0400 Message-Id: <20231008005039.3768522-4-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231008005039.3768522-1-sashal@kernel.org> References: <20231008005039.3768522-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.295 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit b13e59e74ff71a1004e0508107e91e9a84fd7388 ] I2C_CLASS_DEPRECATED is a flag and not an actual class. There's nothing speaking against both, parent and child, having I2C_CLASS_DEPRECATED set. Therefore exclude it from the check. Signed-off-by: Heiner Kallweit Acked-by: Peter Rosin Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/i2c-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c index f330690b41253..83a79bcb71ea5 100644 --- a/drivers/i2c/i2c-mux.c +++ b/drivers/i2c/i2c-mux.c @@ -334,7 +334,7 @@ int i2c_mux_add_adapter(struct i2c_mux_core *muxc, priv->adap.lock_ops = &i2c_parent_lock_ops; /* Sanity check on class */ - if (i2c_mux_parent_classes(parent) & class) + if (i2c_mux_parent_classes(parent) & class & ~I2C_CLASS_DEPRECATED) dev_err(&parent->dev, "Segment %d behind mux can't share classes with ancestors\n", chan_id); -- 2.40.1