mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sarah Walker <sarah.walker@imgtec.com>
To: <dri-devel@lists.freedesktop.org>
Cc: <frank.binns@imgtec.com>, <donald.robson@imgtec.com>,
	<boris.brezillon@collabora.com>, <faith.ekstrand@collabora.com>,
	<airlied@gmail.com>, <daniel@ffwll.ch>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <afd@ti.com>, <hns@goldelico.com>,
	<matthew.brost@intel.com>, <christian.koenig@amd.com>,
	<luben.tuikov@amd.com>, <dakr@redhat.com>,
	<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <corbet@lwn.net>,
	<linux-doc@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Conor Dooley <conor.dooley@microchip.com>
Subject: [PATCH v7 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU
Date: Tue, 10 Oct 2023 14:37:21 +0100	[thread overview]
Message-ID: <20231010133738.35274-4-sarah.walker@imgtec.com> (raw)
In-Reply-To: <20231010133738.35274-1-sarah.walker@imgtec.com>

Add the device tree binding documentation for the IMG AXE GPU used in
TI AM62 SoCs.

Co-developed-by: Frank Binns <frank.binns@imgtec.com>
Signed-off-by: Frank Binns <frank.binns@imgtec.com>
Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
Changes since v6:
- Remove unused gpu label from example
- Updated maintainer

Changes since v5:
- Update compatible string & description to match marketing name
- Remove unnecessary clock-names definition in ti,am62-gpu constraints
- Document that GPU revision is discoverable

Changes since v4:
- Add clocks constraint for ti,am62-gpu
- Remove excess address and size cells in example
- Remove interrupt name and add maxItems
- Make property order consistent between dts and bindings doc
- Update example to match dts

Changes since v3:
- Remove oneOf in compatible property
- Remove power-supply (not used on AM62)

Changes since v2:
- Add commit message description
- Remove mt8173-gpu support (not currently supported)
- Drop quotes from $id and $schema
- Remove reg: minItems
- Drop _clk suffixes from clock-names
- Remove operating-points-v2 property and cooling-cells (not currently
  used)
- Add additionalProperties: false
- Remove stray blank line at the end of file

 .../devicetree/bindings/gpu/img,powervr.yaml  | 73 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++
 2 files changed, 79 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr.yaml

diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr.yaml
new file mode 100644
index 000000000000..e81db87a1f46
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/img,powervr.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2023 Imagination Technologies Ltd.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpu/img,powervr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Imagination Technologies PowerVR and IMG GPU
+
+maintainers:
+  - Donald Robson <donald.robson@imgtec.com>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - ti,am62-gpu
+      - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+    maxItems: 3
+
+  clock-names:
+    items:
+      - const: core
+      - const: mem
+      - const: sys
+    minItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+
+additionalProperties: false
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,am62-gpu
+    then:
+      properties:
+        clocks:
+          maxItems: 1
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/soc/ti,sci_pm_domain.h>
+
+    gpu@fd00000 {
+        compatible = "ti,am62-gpu", "img,img-axe";
+        reg = <0x0fd00000 0x20000>;
+        clocks = <&k3_clks 187 0>;
+        clock-names = "core";
+        interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+        power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index e05506ea8917..eea8e618746a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10228,6 +10228,12 @@ IMGTEC IR DECODER DRIVER
 S:	Orphan
 F:	drivers/media/rc/img-ir/
 
+IMGTEC POWERVR DRM DRIVER
+M:	Frank Binns <frank.binns@imgtec.com>
+M:	Donald Robson <donald.robson@imgtec.com>
+S:	Supported
+F:	Documentation/devicetree/bindings/gpu/img,powervr.yaml
+
 IMON SOUNDGRAPH USB IR RECEIVER
 M:	Sean Young <sean@mess.org>
 L:	linux-media@vger.kernel.org
-- 
2.42.0


  parent reply	other threads:[~2023-10-10 13:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 13:37 [PATCH v7 00/20] Imagination Technologies PowerVR DRM driver Sarah Walker
2023-10-10 13:37 ` [PATCH v7 01/20] sizes.h: Add entries between SZ_32G and SZ_64T Sarah Walker
2023-10-10 13:37 ` [PATCH v7 02/20] drm/gpuvm: Helper to get range of unmap from a remap op Sarah Walker
2023-10-10 16:31   ` Danilo Krummrich
2023-10-12  9:57     ` [EXTERNAL] " Donald Robson
2023-10-10 13:37 ` Sarah Walker [this message]
2023-10-10 13:37 ` [PATCH v7 04/20] drm/imagination/uapi: Add PowerVR driver UAPI Sarah Walker
2023-10-10 13:37 ` [PATCH v7 05/20] drm/imagination: Add skeleton PowerVR driver Sarah Walker
2023-10-10 13:37 ` [PATCH v7 06/20] drm/imagination: Get GPU resources Sarah Walker
2023-10-10 13:37 ` [PATCH v7 07/20] drm/imagination: Add GPU register headers Sarah Walker
2023-10-10 13:37 ` [PATCH v7 08/20] drm/imagination: Add firmware and MMU related headers Sarah Walker
2023-10-10 13:37 ` [PATCH v7 09/20] drm/imagination: Add FWIF headers Sarah Walker
2023-10-10 13:37 ` [PATCH v7 10/20] drm/imagination: Add GPU ID parsing and firmware loading Sarah Walker
2023-10-12  6:58   ` kernel test robot
2023-10-10 13:37 ` [PATCH v7 11/20] drm/imagination: Add GEM and VM related code Sarah Walker
2023-10-13 12:47   ` kernel test robot
2023-10-10 13:37 ` [PATCH v7 12/20] drm/imagination: Implement power management Sarah Walker
2023-10-10 13:37 ` [PATCH v7 13/20] drm/imagination: Implement firmware infrastructure and META FW support Sarah Walker
2023-10-10 13:37 ` [PATCH v7 14/20] drm/imagination: Implement MIPS firmware processor and MMU support Sarah Walker
2023-10-10 13:37 ` [PATCH v7 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls Sarah Walker
2023-10-10 13:37 ` [PATCH v7 16/20] drm/imagination: Implement context creation/destruction ioctls Sarah Walker
2023-10-10 13:37 ` [PATCH v7 17/20] drm/imagination: Implement job submission and scheduling Sarah Walker
2023-10-10 13:37 ` [PATCH v7 18/20] drm/imagination: Add firmware trace header Sarah Walker
2023-10-10 13:37 ` [PATCH v7 19/20] drm/imagination: Add firmware trace to debugfs Sarah Walker
2023-10-10 13:37 ` [PATCH v7 20/20] drm/imagination: Add driver documentation Sarah Walker
2023-10-19 10:12 ` [PATCH v7 00/20] Imagination Technologies PowerVR DRM driver Maxim Kochetkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010133738.35274-4-sarah.walker@imgtec.com \
    --to=sarah.walker@imgtec.com \
    --cc=afd@ti.com \
    --cc=airlied@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=christian.koenig@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=corbet@lwn.net \
    --cc=dakr@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=donald.robson@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=faith.ekstrand@collabora.com \
    --cc=frank.binns@imgtec.com \
    --cc=hns@goldelico.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.brost@intel.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®