mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <reinette.chatre@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
Cc: <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
	<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
	<songmuchun@bytedance.com>, <peterz@infradead.org>,
	<jpoimboe@kernel.org>, <pbonzini@redhat.com>,
	<babu.moger@amd.com>, <chang.seok.bae@intel.com>,
	<pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
	<daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
	<tony.luck@intel.com>, <james.morse@arm.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<bagasdotme@gmail.com>, <eranian@google.com>,
	<christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
	<adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
	<peternewman@google.com>
Subject: [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy
Date: Tue, 10 Oct 2023 18:33:29 -0500	[thread overview]
Message-ID: <20231010233335.998475-5-babu.moger@amd.com> (raw)
In-Reply-To: <20231010233335.998475-1-babu.moger@amd.com>

resctrl uses RFTYPE flags for creating resctrl directory structure.

Definitions and directory structures are not documented. Add
comments to improve the readability and help future additions.

Signed-off-by: Babu Moger <babu.moger@amd.com>
Tested-by: Peter Newman <peternewman@google.com>
Reviewed-by: Peter Newman <peternewman@google.com>
Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
v12: Moved the comments from arch/x86/kernel/cpu/resctrl/internal.h
     to Documentation/arch/x86/resctrl.rst. (Boris)
---
 Documentation/arch/x86/resctrl.rst | 60 ++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
index 8154e9975d1e..520a7753d829 100644
--- a/Documentation/arch/x86/resctrl.rst
+++ b/Documentation/arch/x86/resctrl.rst
@@ -362,6 +362,66 @@ When monitoring is enabled all MON groups will also contain:
 	the sum for all tasks in the CTRL_MON group and all tasks in
 	MON groups. Please see example section for more details on usage.
 
+RESCTRL filesystem implementation notes
+=======================================
+RESCTRL filesystem has two main components
+	a. info
+	b. base
+
+/sys/fs/resctrl/
+	|
+	--> info (Top level directory named "info". Contains files that
+	|	  provide details on control and monitoring resources)
+	|
+	--> base (Root directory associated with default resource group
+		  as well as directories created by user for MON and CTRL
+		  groups. Contains files to interact with MON and CTRL
+		  groups)
+
+	Note: resctrl uses flags for files, not for directories.
+	      Directories are created based on the resource type. Added
+	      directories below for better understanding. The RFTYPE flags
+	      are defined in arch/x86/kernel/cpu/resctrl/internal.h.
+
+	info directory structure
+	---------------------------------------------------------------
+	--> RFTYPE_INFO
+	    Directory: info
+	--> RFTYPE_TOP (Files in top level of info directory)
+	    File: last_cmd_status
+
+	--> RFTYPE_MON (Files for all monitoring resources)
+	    Directory: L3_MON
+	        Files: mon_features, num_rmids
+
+		--> RFTYPE_RES_CACHE (Files for cache monitoring resources)
+		    Directory: L3_MON
+		        Files: max_threshold_occupancy,
+		               mbm_total_bytes_config,
+		               mbm_local_bytes_config
+
+	--> RFTYPE_CTRL (Files for all control resources)
+	    Directories: L2, L3, MB, SMBA, L2CODE, L2DATA, L3CODE, L3DATA
+	           File: num_closids
+
+		--> RFTYPE_RES_CACHE (Files for cache control resources)
+		    Directories: L2, L3, L2CODE, L2DATA, L3CODE, L3DATA
+		          Files: bit_usage, cbm_mask, min_cbm_bits,
+		                 shareable_bits
+
+		--> RFTYPE_RES_MB (Files for memory control resources)
+		    Directories: MB, SMBA
+		          Files: bandwidth_gran, delay_linear,
+		                 min_bandwidth, thread_throttle_mode
+
+	base directory structure
+	---------------------------------------------------------------
+	--> RFTYPE_BASE (Files common for both MON and CTRL groups)
+	    Files: cpus, cpus_list, tasks
+
+		--> RFTYPE_CTRL (Files for CTRL group)
+		    Files: mode, schemata, size
+
 Resource allocation rules
 -------------------------
 
-- 
2.34.1


  parent reply	other threads:[~2023-10-10 23:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 23:33 [PATCH v12 00/10] x86/resctrl: Miscellaneous resctrl features Babu Moger
2023-10-10 23:33 ` [PATCH v12 01/10] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-10-10 23:33 ` [PATCH v12 02/10] x86/resctrl: Simplify rftype flag definitions Babu Moger
2023-10-10 23:33 ` [PATCH v12 03/10] x86/resctrl: Rename rftype flags for consistency Babu Moger
2023-10-10 23:33 ` Babu Moger [this message]
2023-10-11  0:56   ` [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy Reinette Chatre
2023-10-11 16:57     ` Moger, Babu
2023-10-12 16:01       ` Reinette Chatre
2023-10-12 18:28         ` Moger, Babu
2023-10-10 23:33 ` [PATCH v12 05/10] x86/resctrl: Unwind the errors inside rdt_enable_ctx() Babu Moger
2023-10-10 23:33 ` [PATCH v12 06/10] x86/resctrl: Move default group file creation to mount Babu Moger
2023-10-10 23:33 ` [PATCH v12 07/10] x86/resctrl: Introduce "-o debug" mount option Babu Moger
2023-10-10 23:33 ` [PATCH v12 08/10] x86/resctrl: Display CLOSID for resource group Babu Moger
2023-10-10 23:33 ` [PATCH v12 09/10] x86/resctrl: Add support for the files for MON groups only Babu Moger
2023-10-12 16:02   ` Reinette Chatre
2023-10-12 18:29     ` Moger, Babu
2023-10-10 23:33 ` [PATCH v12 10/10] x86/resctrl: Display RMID of resource group Babu Moger
2023-10-12 16:02   ` Reinette Chatre
2023-10-12 22:06     ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010233335.998475-5-babu.moger@amd.com \
    --to=babu.moger@amd.com \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jarkko@kernel.org \
    --cc=jmattson@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peternewman@google.com \
    --cc=peterz@infradead.org \
    --cc=quic_jiles@quicinc.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rdunlap@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=sandipan.das@amd.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®