From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dafna Hirschfeld <dhirschfeld@habana.ai>,
Dani Liberman <dliberman@habana.ai>,
Koby Elbaz <kelbaz@habana.ai>, Ofir Bitton <obitton@habana.ai>,
Ohad Sharabi <osharabi@habana.ai>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Tal Cohen <talcohen@habana.ai>, Tomer Tayar <ttayar@habana.ai>
Subject: Re: [PATCH] accel/habanalabs: make hl_class constant
Date: Tue, 10 Oct 2023 08:34:13 +0200 [thread overview]
Message-ID: <2023101053-clambake-mollusk-2953@gregkh> (raw)
In-Reply-To: <CAFCwf10o8J2JYue9Spc0qmSnH671ySuDeUggJ3J6mhXVTc7kTA@mail.gmail.com>
On Tue, Oct 10, 2023 at 09:07:53AM +0300, Oded Gabbay wrote:
> On Fri, Oct 6, 2023 at 4:57 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Now that the driver core allows for struct class to be in read-only
> > memory, we should make all 'class' structures declared at build time
> > placing them into read-only memory, instead of having to be dynamically
> > allocated at runtime.
> >
> > This requires some passing of const struct class * around in the common
> > habanalabs code as well as converting the structure itself.
>
> Hi Greg,
> Thanks for the patch but if you look at our tip of habanalabs-next
> branch (to be merged in 6.7), you will see the hl_class related code
> no longer exists, as we moved completely to the new accel char device
> class.
> So, I'm dropping this patch.
Ah, no code is better, thanks!
greg k-h
prev parent reply other threads:[~2023-10-10 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 13:56 Greg Kroah-Hartman
2023-10-10 6:07 ` Oded Gabbay
2023-10-10 6:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101053-clambake-mollusk-2953@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dhirschfeld@habana.ai \
--cc=dliberman@habana.ai \
--cc=dri-devel@lists.freedesktop.org \
--cc=kelbaz@habana.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=obitton@habana.ai \
--cc=ogabbay@kernel.org \
--cc=osharabi@habana.ai \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=talcohen@habana.ai \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®