From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] spi: Don't use flexible array in struct spi_message definition
Date: Wed, 11 Oct 2023 09:00:27 +0200 [thread overview]
Message-ID: <20231011-lemon-exert-e4d695a5cb7e-mkl@pengutronix.de> (raw)
In-Reply-To: <20231010163100.89734-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On 10.10.2023 19:31:00, Andy Shevchenko wrote:
> The struct spi_message can be embedded into another structures.
> With that the flexible array might be problematic as sparse
> complains about it, although there is no real issue in the code
> because when the message is embedded it doesn't use flexible array
> member. That memeber is a private to spi_message_alloc() API, so
> move it to that API in a form of an inherited data type.
>
> Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Fixes: 75e308ffc4f0 ("spi: Use struct_size() helper"))
> Closes: https://lore.kernel.org/r/20231009-onshore-underage-c58415adfd92-mkl@pengutronix.de
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
Thank you for the timely fix!
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-11 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 16:31 Andy Shevchenko
2023-10-11 7:00 ` Marc Kleine-Budde [this message]
2023-10-11 18:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011-lemon-exert-e4d695a5cb7e-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®