From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBC6CD6E6E for ; Wed, 11 Oct 2023 13:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234942AbjJKNln (ORCPT ); Wed, 11 Oct 2023 09:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232091AbjJKNlj (ORCPT ); Wed, 11 Oct 2023 09:41:39 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4055090; Wed, 11 Oct 2023 06:41:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8121EC15; Wed, 11 Oct 2023 06:42:18 -0700 (PDT) Received: from bogus (unknown [10.57.93.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C229D3F5A1; Wed, 11 Oct 2023 06:41:35 -0700 (PDT) Date: Wed, 11 Oct 2023 14:40:03 +0100 From: Sudeep Holla To: Ranjani Vaidyanathan Cc: Cristian Marussi , "Peng Fan (OSS)" , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "souvik.chakravarty@arm.com" , Glen G Wienecke , Peng Fan Subject: Re: [EXT] Re: [RFC] firmware: arm_scmi: clock: add fixed clock attribute support Message-ID: <20231011134003.lhb5yiicgr5cbzr2@bogus> References: <20231010022911.4106863-1-peng.fan@oss.nxp.com> <20231010091223.rvcyrgbjcrmjzmvp@bogus> <20231010093509.ddy75og4jd72n6cq@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2023 at 03:54:59AM +0000, Ranjani Vaidyanathan wrote: > From what I see SCMI clock protocol could benefit from an attribute for the > clock that describes what operations are possible on a clock. There are many > bus clocks that only the SCMI server manages and the error code DENIED > should be handled gracefully by the agent. > Agreed, but we need to understand if we need it per operation basis or at the higher granularity such as any write or set operations not allowed. Just my initial thoughts, we can discuss. > In the case of Linux, perhaps this should be handled by the SCMI clock > driver, instead of allowing the error to propagate up the Linux clock > framework? Yes but even for that we need information from the firmware. > It seems strange that the SCMI server should swallow the error (silently > fail) only for certain agents. I am bit confused by this statement. The SCMI server/platform must not ignore or fail silently. Since the agent is not allowed, if it attempts it must return the apt error. While Linux may choose to ignore the error but I think this is what we are discussing to figure out what is the best way to avoid it or worst case handle it gracefully. With any extra info from the firmware, the former option must be possible and we need not think of the latter option IMO. > I would think this would make debug quite difficult and having a "DENIED" > error code not very useful. > Agreed especially if it can and is expected to continue functioning as normal. -- Regards, Sudeep