From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6677CD6E7B for ; Wed, 11 Oct 2023 14:40:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346721AbjJKOkN (ORCPT ); Wed, 11 Oct 2023 10:40:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232323AbjJKOkM (ORCPT ); Wed, 11 Oct 2023 10:40:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 29436B6; Wed, 11 Oct 2023 07:40:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0AF4106F; Wed, 11 Oct 2023 07:40:50 -0700 (PDT) Received: from bogus (unknown [10.57.93.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EDF843F7A6; Wed, 11 Oct 2023 07:40:07 -0700 (PDT) Date: Wed, 11 Oct 2023 15:38:36 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Arnd Bergmann , Rob Herring , Frank Rowand , Sudeep Holla , Greg Kroah-Hartman , Yang Yang , Geert Uytterhoeven , Sebastian Reichel , Miquel Raynal , Dmitry Baryshkov , Viresh Kumar , Benjamin Herrenschmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: rexport of_find_next_cache_node() Message-ID: <20231011143836.q4c5rf6eqb2i6p53@bogus> References: <20231011131431.2559029-1-arnd@kernel.org> <20231011135905.hveat7viflqluccw@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2023 at 04:05:47PM +0200, Arnd Bergmann wrote: > On Wed, Oct 11, 2023, at 15:59, Sudeep Holla wrote: > > On Wed, Oct 11, 2023 at 03:14:08PM +0200, Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> This function is now called from a cpufreq driver, but that breaks the > >> build when the caller is in a loadable module, because of a missing > >> export: > >> > >> ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined! > >> > >> Export this as a GPL-only symbol, like the other related functions in > >> this file. > >> > >> Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device") > >> Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.") > > > > I am bit confused as I see commit a3e31b4588443 didn't drop the export. > > So how is this change fixing that commit ? > > My mistake, I was looking for the commit that initially introduced > the function, but didn't notice that this just moved it from powerpc. > > I could have used "Fixes: e523f723d69cd ("powerpc: Add > of_find_next_cache_node()")", but it's probably best to just > leave that line out entirely. > Yes I was thinking to drop it as it is quite old commit(both a3e31b4588443 and e523f723d69cd) and I don't see any point in merging this to all the concerned stable trees as they must not have this new user. That said it is not a complex change, so I am fine either way, just thought of raising it in case it was not intentional. -- Regards, Sudeep