From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6B0CDB482 for ; Thu, 12 Oct 2023 13:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379046AbjJLN7o (ORCPT ); Thu, 12 Oct 2023 09:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343887AbjJLN7m (ORCPT ); Thu, 12 Oct 2023 09:59:42 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1951D91; Thu, 12 Oct 2023 06:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=FnHNdC38Q+jXiFUjhIBZEqns97kQogNNrTq30YKI45A=; b=VbUIPx6Wr2kY0vEm8LGHv1IwtJ m0hYSYDIXmWGEXRrNd1N/2yhyPjhAdpfJGcVvnDMUNqUl1fXXLigNkOW9HCBCBdvznmKE/2sBF2PE e/FwMoVB5BR1J5plX7dRv1rw6DoXYDlMIXNmjxFd3sdbSnMbcdKQHWaNi7IIbRf3izaA=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:58068 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qqwDw-0002dW-0S; Thu, 12 Oct 2023 09:59:36 -0400 Date: Thu, 12 Oct 2023 09:59:35 -0400 From: Hugo Villeneuve To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hugo Villeneuve , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Message-Id: <20231012095935.0bf2c58c424559492e7f5c25@hugovil.com> In-Reply-To: References: <20231011222105.2587175-1-hugo@hugovil.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] dt-bindings: max310x: convert to YAML X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Oct 2023 09:53:02 +0200 Krzysztof Kozlowski wrote: > On 12/10/2023 00:21, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > > > Convert binding from text format to YAML. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. Missing prefix: serial: Hi, will add it for V2. > > > > Additions to original text binding: > > - add rs485 reference. > > > > Signed-off-by: Hugo Villeneuve > > --- > > > > diff --git a/Documentation/devicetree/bindings/serial/maxim,max310x.yaml b/Documentation/devicetree/bindings/serial/maxim,max310x.yaml > > new file mode 100644 > > index 000000000000..05fd00d95260 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/maxim,max310x.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/maxim,max310x.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim MAX310X Advanced Universal Asynchronous Receiver-Transmitter (UART) > > + > > +maintainers: > > + - Hugo Villeneuve > > + > > +properties: > > + compatible: > > + enum: > > + - maxim,max3107 > > + - maxim,max3108 > > + - maxim,max3109 > > + - maxim,max14830 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-frequency: > > + description: > > + When there is no clock provider visible to the platform, this > > + is the source crystal frequency for the IC in Hz. > > + minimum: 1000000 > > + maximum: 4000000 > > This wasn't in original binding. Explain this in the commit msg. I will add the corresponding explanation in V2. The 'clock-frequency' property is already supported by the driver but was not documented in the original txt binding. This is related to the commit d4d6f03c4fb3: serial: max310x: Try to get crystal clock rate from property (Author: Andy Shevchenko): In some configurations, mainly ACPI-based, the clock frequency of the device is supplied by very well established 'clock-frequency' property. Hence, try to get it from the property at last if no other providers are available. > > > + > > + clock-names: > > + enum: > > + - xtal # External crystal > > + - osc # External clock source > > clock-names follow immediately clocks. Will fix for V2. > > > + > > + gpio-controller: true > > + > > + "#gpio-cells": > > + const: 2 > > + > > + gpio-line-names: > > + minItems: 1 > > + maxItems: 16 > > + > > +allOf: > > allOf: block goes after required: block. Will fix for V2. > > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + - $ref: /schemas/serial/serial.yaml# > > + - $ref: /schemas/serial/rs485.yaml# > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +oneOf: > > + - required: > > + - clocks > > + - clock-names > > + - required: > > + - clock-frequency > > That's also something new as well. The original binding required clocks. > Why are you changing this? See explanation above about clock-frequency. If clocks is not provided, than at least 'clock-frequency' must be provided. > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + serial@2c { > > + compatible = "maxim,max3107"; > > + reg = <0x2c>; > > + clocks = <&xtal4m>; > > + clock-names = "xtal"; > > + interrupt-parent = <&gpio3>; > > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + }; > > + > > One example is enuogh. All other are the same. Not really, clock-names is different for example 2 (osc), and example 3 shows that 'clock-frequency' can be used if no clock is provided? Hugo.