From: Christopher Obbard <chris.obbard@collabora.com>
To: linux-rockchip@lists.infradead.org
Cc: kernel@collabora.com,
Christopher Obbard <chris.obbard@collabora.com>,
Arnaud Ferraris <arnaud.ferraris@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Caleb Connolly <kc@postmarketos.org>,
Conor Dooley <conor+dt@kernel.org>,
Corentin Labbe <clabbe@baylibre.com>,
FUKAUMI Naoki <naoki@radxa.com>, Heiko Stuebner <heiko@sntech.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Johan Jonker <jbx6244@gmail.com>,
Judy Hsiao <judyhsiao@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rick Wertenbroek <rick.wertenbroek@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Yogesh Hegde <yogi.kernel@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 0/2] Fix i2s0 pin conflict on ROCK Pi 4 RK3399 boards
Date: Fri, 13 Oct 2023 12:47:25 +0100 [thread overview]
Message-ID: <20231013114737.494410-1-chris.obbard@collabora.com> (raw)
i2s0 fails to probe on my Radxa ROCK 4SE and ROCK Pi 4B boards with:
rockchip-pinctrl pinctrl: pin gpio3-29 already requested by leds; cannot claim for ff880000.i2s
rockchip-pinctrl pinctrl: pin-125 (ff880000.i2s) status -22
rockchip-pinctrl pinctrl: could not request pin 125 (gpio3-29) from group i2s0-8ch-bus-bclk-off on device rockchip-pinctrl
rockchip-i2s ff880000.i2s: Error applying setting, reverse things back
rockchip-i2s ff880000.i2s: bclk disable failed -22
This is due to the pinctl attempting to request a GPIO which the boards
use for a different function.
The first patch adds a missing pinctl node i2s0_2ch_bus_bclk_off to the
RK3399 devicetree.
The second patch sets the i2s0 pinctrl to use the new node when idle and
fixes the issue.
Christopher Obbard (2):
arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399
arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++
2 files changed, 11 insertions(+)
--
2.42.0
next reply other threads:[~2023-10-13 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 11:47 Christopher Obbard [this message]
2023-10-13 11:47 ` [PATCH v1 1/2] arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399 Christopher Obbard
2023-10-13 11:47 ` [PATCH v1 2/2] arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards Christopher Obbard
2023-10-13 14:11 ` [PATCH v1 0/2] Fix i2s0 pin conflict on ROCK Pi 4 RK3399 boards Folker Schwesinger
2023-10-16 20:12 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013114737.494410-1-chris.obbard@collabora.com \
--to=chris.obbard@collabora.com \
--cc=arnaud.ferraris@collabora.com \
--cc=briannorris@chromium.org \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=judyhsiao@chromium.org \
--cc=kc@postmarketos.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=rick.wertenbroek@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®