mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
	apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com
Subject: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'
Date: Fri, 13 Oct 2023 10:27:39 -0700	[thread overview]
Message-ID: <20231013172739.1113964-1-kuba@kernel.org> (raw)

syzbot stack traces often come with the following line:

 Hardware name: Google Google Compute Engine/Google Compute Engine...

This generates the repeated word warning from checkpatch.
It hit 49 times in the last 6 months in networking
(false-positive rate of 0.34%). Mute the warning for "Google",
there's no other word which comes close to being this clear
cut false-positive in our traffic.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: apw@canonical.com
CC: joe@perches.com
CC: dwaipayanray1@gmail.com
CC: lukas.bulwahn@gmail.com
---
 scripts/checkpatch.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7d16f863edf1..c99f8f93cb4c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3524,6 +3524,8 @@ sub process {
 
 				next if (lc($first) ne lc($second));
 				next if ($first eq 'long');
+				# syzbot reports contain "Hardware name: Google Google Compute Engine"
+				next if ($first eq 'Google');
 
 				# check for character before and after the word matches
 				my $start_char = '';
-- 
2.41.0


             reply	other threads:[~2023-10-13 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 17:27 Jakub Kicinski [this message]
2023-10-13 18:11 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231013172739.1113964-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®