From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Yang Jihong <yangjihong1@huawei.com>
Subject: [RFC PATCH v2 14/17] perf stat: Handle NMI in hardware-grouping
Date: Fri, 13 Oct 2023 18:51:59 -0700 [thread overview]
Message-ID: <20231014015202.1175377-15-weilin.wang@intel.com> (raw)
In-Reply-To: <20231014015202.1175377-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
Add an easy nmi watchdog support in grouping. When nmi watchdog is enabled,
we reduce the total num of events could be assigned to one group by 1. A
more efficient solution will be added in later.
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
tools/perf/util/metricgroup.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 100c9d948..7da91cbd3 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -1852,6 +1852,10 @@ static int insert_new_group(struct list_head *head,
size_t fixed_size)
{
INIT_LIST_HEAD(&new_group->event_head);
+ if (sysctl__nmi_watchdog_enabled()) {
+ pr_debug("NMI watchdog is enabled\n");
+ size -= 1;
+ }
fill_counter_bitmap(new_group->gp_counters, 0, size);
fill_counter_bitmap(new_group->fixed_counters, 0, fixed_size);
new_group->taken_alone = false;
--
2.39.3
next prev parent reply other threads:[~2023-10-14 1:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 1:51 [RFC PATCH v2 00/17] Perf stat metric grouping with hardware information weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 01/17] perf stat: Add hardware-grouping cmd option to perf stat weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 02/17] perf stat: Add basic functions for the hardware-grouping stat cmd option weilin.wang
2023-10-30 15:07 ` Liang, Kan
2023-10-14 1:51 ` [RFC PATCH v2 03/17] perf pmu-events: Add functions in jevent.py to parse counter and event info for hardware aware grouping weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 04/17] perf pmu-events: Add counter info into JSON files for SapphireRapids weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 05/17] perf pmu-events: Add event counter data for Cascadelakex weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 06/17] perf pmu-events: Add event counter data for Icelakex weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 07/17] perf stat: Add functions to set counter bitmaps for hardware-grouping method weilin.wang
2023-10-30 15:32 ` Liang, Kan
2023-10-30 17:46 ` Wang, Weilin
2023-10-30 18:30 ` Liang, Kan
2023-10-14 1:51 ` [RFC PATCH v2 08/17] perf stat: Add functions to get counter info weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 09/17] perf stat: Add functions to create new group and assign events into groups for hardware-grouping method weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 10/17] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 11/17] perf stat: Add function to handle special events " weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 12/17] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2023-10-14 1:51 ` [RFC PATCH v2 13/17] perf stat: Handle taken alone in hardware-grouping weilin.wang
2023-10-14 1:51 ` weilin.wang [this message]
2023-10-14 1:52 ` [RFC PATCH v2 15/17] perf stat: Code refactoring " weilin.wang
2023-10-14 1:52 ` [RFC PATCH v2 16/17] perf stat: Add tool events support " weilin.wang
2023-10-14 1:52 ` [RFC PATCH v2 17/17] perf pmu-events: Add event counter data for Tigerlake weilin.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014015202.1175377-15-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®