From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8E6CDB465 for ; Sun, 15 Oct 2023 02:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233427AbjJOCw0 (ORCPT ); Sat, 14 Oct 2023 22:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233390AbjJOCwY (ORCPT ); Sat, 14 Oct 2023 22:52:24 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29D95DA for ; Sat, 14 Oct 2023 19:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697338342; x=1728874342; h=date:from:to:cc:subject:message-id:mime-version; bh=T38iPn4QowIZj38APxQ7C2rVzgNZ91IRvo6l8Sg5hUo=; b=nZo+BDNhX5Ho/4lgzHiAqj2WrYWBIjpLad3Tc7PdAWtmFnfx4+cnKTCZ AUJaddkwFtYVtmMHEXlQw1zmnh1wuHwlG9oEfPsHCc2C3OvmmNi3UouzV 7wm1a7zTuo5MHf5n8Py4wQZutoQQvFxfEzGbDILcz4Mc5T9A/vXRUvJO+ b6sZEUblrZCmcd1HTq5V66ztJ3/eh9Ryz6dVG/aZWlxjIpou0O61cazFS HkuPxjCQcmNUfE3JXgXbu4j3ySC5bKjNKHdY8neyLuv5kB5hhIlZCNXkB GMO+cf389V2NTH1Iv293XFV3IRcAGdoZ3S95bEmQb/IRo40Gi8v+hBzxi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="389220939" X-IronPort-AV: E=Sophos;i="6.03,226,1694761200"; d="scan'208";a="389220939" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2023 19:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="705144334" X-IronPort-AV: E=Sophos;i="6.03,226,1694761200"; d="scan'208";a="705144334" Received: from lkp-server02.sh.intel.com (HELO f64821696465) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 14 Oct 2023 19:52:19 -0700 Received: from kbuild by f64821696465 with local (Exim 4.96) (envelope-from ) id 1qrrEn-0006xM-1G; Sun, 15 Oct 2023 02:52:17 +0000 Date: Sun, 15 Oct 2023 10:51:39 +0800 From: kernel test robot To: Anton Ivanov Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Weinberger Subject: arch/um/kernel/skas/uaccess.c:269: warning: Function parameter or member 'op' not described in 'arch_futex_atomic_op_inuser' Message-ID: <202310151047.a07DrQNV-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc9b2e683bcba017588b9aaad80f442ad004a48f commit: dd3035a21ba7ccaa883d7107d357ad06320d78fc um: add a UML specific futex implementation date: 2 years, 4 months ago config: um-allnoconfig (https://download.01.org/0day-ci/archive/20231015/202310151047.a07DrQNV-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231015/202310151047.a07DrQNV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310151047.a07DrQNV-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/um/kernel/skas/uaccess.c:269: warning: Function parameter or member 'op' not described in 'arch_futex_atomic_op_inuser' >> arch/um/kernel/skas/uaccess.c:269: warning: Function parameter or member 'oparg' not described in 'arch_futex_atomic_op_inuser' >> arch/um/kernel/skas/uaccess.c:269: warning: Function parameter or member 'oval' not described in 'arch_futex_atomic_op_inuser' >> arch/um/kernel/skas/uaccess.c:269: warning: Excess function parameter 'encoded_op' description in 'arch_futex_atomic_op_inuser' vim +269 arch/um/kernel/skas/uaccess.c 252 253 /** 254 * arch_futex_atomic_op_inuser() - Atomic arithmetic operation with constant 255 * argument and comparison of the previous 256 * futex value with another constant. 257 * 258 * @encoded_op: encoded operation to execute 259 * @uaddr: pointer to user space address 260 * 261 * Return: 262 * 0 - On success 263 * -EFAULT - User access resulted in a page fault 264 * -EAGAIN - Atomic operation was unable to complete due to contention 265 * -ENOSYS - Operation not supported 266 */ 267 268 int arch_futex_atomic_op_inuser(int op, u32 oparg, int *oval, u32 __user *uaddr) > 269 { 270 int oldval, ret; 271 struct page *page; 272 unsigned long addr = (unsigned long) uaddr; 273 pte_t *pte; 274 275 ret = -EFAULT; 276 if (!access_ok(uaddr, sizeof(*uaddr))) 277 return -EFAULT; 278 preempt_disable(); 279 pte = maybe_map(addr, 1); 280 if (pte == NULL) 281 goto out_inuser; 282 283 page = pte_page(*pte); 284 #ifdef CONFIG_64BIT 285 pagefault_disable(); 286 addr = (unsigned long) page_address(page) + 287 (((unsigned long) addr) & ~PAGE_MASK); 288 #else 289 addr = (unsigned long) kmap_atomic(page) + 290 ((unsigned long) addr & ~PAGE_MASK); 291 #endif 292 uaddr = (u32 *) addr; 293 oldval = *uaddr; 294 295 ret = 0; 296 297 switch (op) { 298 case FUTEX_OP_SET: 299 *uaddr = oparg; 300 break; 301 case FUTEX_OP_ADD: 302 *uaddr += oparg; 303 break; 304 case FUTEX_OP_OR: 305 *uaddr |= oparg; 306 break; 307 case FUTEX_OP_ANDN: 308 *uaddr &= ~oparg; 309 break; 310 case FUTEX_OP_XOR: 311 *uaddr ^= oparg; 312 break; 313 default: 314 ret = -ENOSYS; 315 } 316 #ifdef CONFIG_64BIT 317 pagefault_enable(); 318 #else 319 kunmap_atomic((void *)addr); 320 #endif 321 322 out_inuser: 323 preempt_enable(); 324 325 if (ret == 0) 326 *oval = oldval; 327 328 return ret; 329 } 330 EXPORT_SYMBOL(arch_futex_atomic_op_inuser); 331 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki