From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A54CDB47E for ; Sun, 15 Oct 2023 05:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233497AbjJOFhf (ORCPT ); Sun, 15 Oct 2023 01:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbjJOFhe (ORCPT ); Sun, 15 Oct 2023 01:37:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 268FFA2 for ; Sat, 14 Oct 2023 22:37:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4639FC433C8; Sun, 15 Oct 2023 05:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697348252; bh=cYiN/rDOSxfdgPDehCPj0uNGMsIsA2nH4XQt//rThOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rhLyxXtE2YBZQ/6TVBbyph8qQnh9EKQFvL4amq6L6wMvvedNvdj1VFhX2Q1Rw8k3u dPGHtxvdcH6U4pT8iuhtYA1TUNAMclhlqexO9vKOYSHz2zVU/YuUH0WJmLkj3ePn7E QCQhfdv6vB92+YmfhXcABwvLiMa4GXXWmz+hpk8I= Date: Sun, 15 Oct 2023 07:37:30 +0200 From: Greg Kroah-Hartman To: Soumya Negi Cc: Jonathan Kim , Dean ahn , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] tty: gdm724x: Add blank line after declaration Message-ID: <2023101551-placidly-garnish-3ee7@gregkh> References: <3b24ca9976cf873dbaadb499e09d7b545e9db89c.1697184167.git.soumya.negi97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b24ca9976cf873dbaadb499e09d7b545e9db89c.1697184167.git.soumya.negi97@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2023 at 01:26:35AM -0700, Soumya Negi wrote: > Fix WARNING: Missing a blank line after declarations > Issue found by checkpatch.pl > > Signed-off-by: Soumya Negi > --- > drivers/staging/gdm724x/gdm_tty.c | 1 + > 1 file changed, 1 insertion(+) Why do you have "tty:" as the prefix for a staging driver? Shouldn't it be "staging: gdm724x: ...."? thanks, greg k-h