From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97BA4CDB465 for ; Mon, 16 Oct 2023 08:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjJPIGF (ORCPT ); Mon, 16 Oct 2023 04:06:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjJPIGC (ORCPT ); Mon, 16 Oct 2023 04:06:02 -0400 Received: from out28-218.mail.aliyun.com (out28-218.mail.aliyun.com [115.124.28.218]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B783DE; Mon, 16 Oct 2023 01:05:59 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.2612196|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_news_journal|0.0128076-0.000445282-0.986747;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047208;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=27;RT=27;SR=0;TI=SMTPD_---.V04MZU._1697443545; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.V04MZU._1697443545) by smtp.aliyun-inc.com; Mon, 16 Oct 2023 16:05:53 +0800 From: wangweidong.a@awinic.com To: krzysztof.kozlowski@linaro.org Cc: 13916275206@139.com, alsa-devel@alsa-project.org, arnd@arndb.de, broonie@kernel.org, ckeepax@opensource.cirrus.com, colin.i.king@gmail.com, conor+dt@kernel.org, dan.carpenter@linaro.org, devicetree@vger.kernel.org, fido_max@inbox.ru, herve.codina@bootlin.com, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz, rf@opensource.cirrus.com, robh+dt@kernel.org, ryans.lee@analog.com, sebastian.reichel@collabora.com, shumingf@realtek.com, tiwai@suse.com, trix@redhat.com, wangweidong.a@awinic.com, yijiangtao@awinic.com Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver Date: Mon, 16 Oct 2023 16:05:44 +0800 Message-ID: <20231016080544.45778-1-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> References: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you very much for your review On 13/10/2023 13:50, +200 krzysztof.kozlowski@linaro.org wrote: > On 13/10/2023 12:42, wangweidong.a@awinic.com wrote: >> From: Weidong Wang >> >> Add i2c and amplifier registration for >> aw88399 and their associated operation functions. >> >> + >> +static void aw88399_hw_reset(struct aw88399 *aw88399) >> +{ >> + if (aw88399->reset_gpio) { >> + gpiod_set_value_cansleep(aw88399->reset_gpio, 0); >> + usleep_range(AW88399_1000_US, AW88399_1000_US + 10); >> + gpiod_set_value_cansleep(aw88399->reset_gpio, 1); > Why do you leave the device in reset state? I think you wanted these > reverted. our chip is reset at low level, So I'll change it to gpiod_set_value_cansleep(aw88399->reset_gpio, 1); usleep_range(AW88399_1000_US, AW88399_1000_US + 10); gpiod_set_value_cansleep(aw88399->reset_gpio, 0); usleep_range(AW88399_1000_US, AW88399_1000_US + 10); gpiod_set_value_cansleep(aw88399->reset_gpio, 1); Thanks again for your advice. Best regards, Weidong Wang