From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDF6CDB474 for ; Tue, 17 Oct 2023 15:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344315AbjJQPVn (ORCPT ); Tue, 17 Oct 2023 11:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344302AbjJQPVl (ORCPT ); Tue, 17 Oct 2023 11:21:41 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D476E10C for ; Tue, 17 Oct 2023 08:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697556099; x=1729092099; h=date:from:to:cc:subject:message-id:mime-version; bh=6A7mhFzrHwLNEwh2AOboi0VzZy/07F4DDFeqpCdSzLs=; b=OYPmngb6Z8qeXgTv15rtKKqGnejLS9XJ6j/lz1qGKpmYhHXUJMdr67TT gewhN6tCa82Rl1ydmPTVoEHIT3WCx1FzV1zyayEhHE2dNneoS1W9il5LF Q2u4I30HKX1ZfcChRgb4As1rPk0eL0G6gqdS+p9sBbzH5k+9iC2ftUR/1 7qlKvXOLaNJAztZf9JhwMn0KgOfTcoTBA5BXxJLPAEXXFSmF/d7yepgwv fv4V3RfwR7s37Rev+I6yoWt3Mv+AgO2kDgQhvjPJJRiHPBUpeqvyzXGJn Xwiv6uJLLkLIjqHiLFYUywswbY3D1ctb5zRtOU1D33tUTtHUpah75jFaw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="385644287" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="385644287" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 08:21:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="791260963" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="791260963" Received: from lkp-server02.sh.intel.com (HELO f64821696465) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 17 Oct 2023 08:21:37 -0700 Received: from kbuild by f64821696465 with local (Exim 4.96) (envelope-from ) id 1qslt1-0009jr-1O; Tue, 17 Oct 2023 15:21:35 +0000 Date: Tue, 17 Oct 2023 23:21:17 +0800 From: kernel test robot To: Christian Brauner Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: fs/nilfs2/ioctl.c:133: warning: Function parameter or member 'idmap' not described in 'nilfs_fileattr_set' Message-ID: <202310172314.TUUpcnOg-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c commit: 8782a9aea3ab4d697ad67d1f8ebca38a4e1c24ab fs: port ->fileattr_set() to pass mnt_idmap date: 9 months ago config: x86_64-randconfig-m001-20230717 (https://download.01.org/0day-ci/archive/20231017/202310172314.TUUpcnOg-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172314.TUUpcnOg-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310172314.TUUpcnOg-lkp@intel.com/ All warnings (new ones prefixed by >>): fs/nilfs2/ioctl.c:120: warning: Function parameter or member 'dentry' not described in 'nilfs_fileattr_get' fs/nilfs2/ioctl.c:120: warning: Function parameter or member 'fa' not described in 'nilfs_fileattr_get' >> fs/nilfs2/ioctl.c:133: warning: Function parameter or member 'idmap' not described in 'nilfs_fileattr_set' fs/nilfs2/ioctl.c:133: warning: Function parameter or member 'dentry' not described in 'nilfs_fileattr_set' fs/nilfs2/ioctl.c:133: warning: Function parameter or member 'fa' not described in 'nilfs_fileattr_set' fs/nilfs2/ioctl.c:164: warning: Function parameter or member 'inode' not described in 'nilfs_ioctl_getversion' fs/nilfs2/ioctl.c:164: warning: Function parameter or member 'argp' not described in 'nilfs_ioctl_getversion' vim +133 fs/nilfs2/ioctl.c cde98f0f84ccff Ryusuke Konishi 2011-01-20 127 d623a9420c9ae2 Vyacheslav Dubeyko 2014-01-23 128 /** 7c7c436e14b863 Miklos Szeredi 2021-04-07 129 * nilfs_fileattr_set - ioctl to support chattr d623a9420c9ae2 Vyacheslav Dubeyko 2014-01-23 130 */ 8782a9aea3ab4d Christian Brauner 2023-01-13 131 int nilfs_fileattr_set(struct mnt_idmap *idmap, 7c7c436e14b863 Miklos Szeredi 2021-04-07 132 struct dentry *dentry, struct fileattr *fa) cde98f0f84ccff Ryusuke Konishi 2011-01-20 @133 { 7c7c436e14b863 Miklos Szeredi 2021-04-07 134 struct inode *inode = d_inode(dentry); cde98f0f84ccff Ryusuke Konishi 2011-01-20 135 struct nilfs_transaction_info ti; cde98f0f84ccff Ryusuke Konishi 2011-01-20 136 unsigned int flags, oldflags; cde98f0f84ccff Ryusuke Konishi 2011-01-20 137 int ret; cde98f0f84ccff Ryusuke Konishi 2011-01-20 138 7c7c436e14b863 Miklos Szeredi 2021-04-07 139 if (fileattr_has_fsx(fa)) 7c7c436e14b863 Miklos Szeredi 2021-04-07 140 return -EOPNOTSUPP; cde98f0f84ccff Ryusuke Konishi 2011-01-20 141 7c7c436e14b863 Miklos Szeredi 2021-04-07 142 flags = nilfs_mask_flags(inode->i_mode, fa->flags); cde98f0f84ccff Ryusuke Konishi 2011-01-20 143 cde98f0f84ccff Ryusuke Konishi 2011-01-20 144 ret = nilfs_transaction_begin(inode->i_sb, &ti, 0); cde98f0f84ccff Ryusuke Konishi 2011-01-20 145 if (ret) 7c7c436e14b863 Miklos Szeredi 2021-04-07 146 return ret; cde98f0f84ccff Ryusuke Konishi 2011-01-20 147 7c7c436e14b863 Miklos Szeredi 2021-04-07 148 oldflags = NILFS_I(inode)->i_flags & ~FS_FL_USER_MODIFIABLE; 7c7c436e14b863 Miklos Szeredi 2021-04-07 149 NILFS_I(inode)->i_flags = oldflags | (flags & FS_FL_USER_MODIFIABLE); cde98f0f84ccff Ryusuke Konishi 2011-01-20 150 cde98f0f84ccff Ryusuke Konishi 2011-01-20 151 nilfs_set_inode_flags(inode); 078cd8279e6599 Deepa Dinamani 2016-09-14 152 inode->i_ctime = current_time(inode); cde98f0f84ccff Ryusuke Konishi 2011-01-20 153 if (IS_SYNC(inode)) cde98f0f84ccff Ryusuke Konishi 2011-01-20 154 nilfs_set_transaction_flag(NILFS_TI_SYNC); cde98f0f84ccff Ryusuke Konishi 2011-01-20 155 cde98f0f84ccff Ryusuke Konishi 2011-01-20 156 nilfs_mark_inode_dirty(inode); 7c7c436e14b863 Miklos Szeredi 2021-04-07 157 return nilfs_transaction_commit(inode->i_sb); cde98f0f84ccff Ryusuke Konishi 2011-01-20 158 } cde98f0f84ccff Ryusuke Konishi 2011-01-20 159 :::::: The code at line 133 was first introduced by commit :::::: cde98f0f84ccff78e87235cb7b551747d6ad00de nilfs2: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION :::::: TO: Ryusuke Konishi :::::: CC: Ryusuke Konishi -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki