From: Greg KH <gregkh@linuxfoundation.org>
To: Ekansh Gupta <quic_ekangupt@quicinc.com>
Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org,
ekangupt@qti.qualcomm.com, linux-kernel@vger.kernel.org,
fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH v4 4/5] misc: fastrpc: Add support to save and restore interrupted
Date: Tue, 17 Oct 2023 18:10:08 +0200 [thread overview]
Message-ID: <2023101743-discern-plunging-83e4@gregkh> (raw)
In-Reply-To: <d800dcbf-83dc-4b0f-bdd3-fc0efb5dd771@quicinc.com>
On Tue, Oct 17, 2023 at 08:36:28PM +0530, Ekansh Gupta wrote:
>
> On 10/17/2023 6:50 PM, Greg KH wrote:
> > On Tue, Oct 17, 2023 at 02:56:38PM +0530, Ekansh Gupta wrote:
> > > For any remote call, driver sends a message to DSP using RPMSG
> > > framework. After message is sent, there is a wait on a completion
> > > object at driver which is completed when DSP response is received.
> > >
> > > There is a possibility that a signal is received while waiting
> > > causing the wait function to return -ERESTARTSYS. In this case
> > > the context should be saved and it should get restored for the
> > > next invocation for the thread.
> > >
> > > Adding changes to support saving and restoring of interrupted
> > > fastrpc contexts.
> > >
> > > Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
> > > Change-Id: Ia101acf7c1bf6018635536082bf7ea009093c948
> > > ---
> > > Changes in v2:
> > > - Fixed missing definition
> > > - Fixes compile time issue
> > You forgot to run checkpatch.pl :(
>
> I did run checkpatch.pl and also tried compilation test. checkpatch.pl is
> suggesting 0 errors, 0 warning and compilation also worked without any
> errors. I might have checked on last week's base as there were no changes in
> these files. I'll check the patches with latest version and update again if
> any errors/warnings are observed. Thanks for reviewing the patch. -ekansh
The "Change-Id:" should not be there, and I thought checkpatch would
catch that. If not, no big deal, you should have :)
next prev parent reply other threads:[~2023-10-17 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:26 [PATCH v4 0/5] Add multimode invoke request IOCTL support Ekansh Gupta
2023-10-17 9:26 ` [PATCH v4 1/5] misc: fastrpc: Add fastrpc multimode invoke request support Ekansh Gupta
2023-10-17 9:26 ` [PATCH v4 2/5] misc: fastrpc: Add CRC support for remote buffers Ekansh Gupta
2023-10-17 9:26 ` [PATCH v4 3/5] misc: fastrpc: Capture kernel and DSP performance counters Ekansh Gupta
2023-10-17 9:26 ` [PATCH v4 4/5] misc: fastrpc: Add support to save and restore interrupted Ekansh Gupta
2023-10-17 13:20 ` Greg KH
2023-10-17 15:06 ` Ekansh Gupta
2023-10-17 16:10 ` Greg KH [this message]
2023-10-18 5:12 ` Ekansh Gupta
2023-10-17 9:26 ` [PATCH v4 5/5] misc: fastrpc: Add support to allocate shared context bank Ekansh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101743-discern-plunging-83e4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ekangupt@qti.qualcomm.com \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ekangupt@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®