From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546FECDB483 for ; Wed, 18 Oct 2023 11:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbjJRLtR (ORCPT ); Wed, 18 Oct 2023 07:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbjJRLtP (ORCPT ); Wed, 18 Oct 2023 07:49:15 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BBE2111; Wed, 18 Oct 2023 04:49:13 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D0E752B3; Wed, 18 Oct 2023 13:49:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697629745; bh=fJTg0p90iZsCaFDhrtNZ4cK233vjH3fuyCAW+LUdm6c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UzLRwX0Rx1eEQZdYIHxP15ldj265YRAQkCj9YC4BjMMQ7zG9GDcL+I8DtaWz6txg8 e5VqL9YFaYvJRReJMXoFhLnvS3t0BJowR6bPJJmsfjO8L4o+96IyqLOrxshd2gVzZj OHVr7E8qn3q/dwyP6+aqftLRjmqYHuyWNKyibtwM= Date: Wed, 18 Oct 2023 14:49:19 +0300 From: Laurent Pinchart To: Jack Zhu Cc: Hans Verkuil , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , bryan.odonoghue@linaro.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Philipp Zabel , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev, changhuang.liang@starfivetech.com Subject: Re: [PATCH v10 0/8] Add StarFive Camera Subsystem driver Message-ID: <20231018114919.GF11118@pendragon.ideasonboard.com> References: <20231008085154.6757-1-jack.zhu@starfivetech.com> <98297bfc-ab81-4bb5-acc3-619fdf879276@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2023 at 11:11:40AM +0800, Jack Zhu wrote: > On 2023/10/16 19:40, Hans Verkuil wrote: > > On 08/10/2023 10:51, Jack Zhu wrote: > >> Hi, > >> > >> This series is the v10 series that attempts to support the Camera Subsystem > >> found on StarFive JH7110 SoC. > >> > >> This series is based on top of the master branch of media_stage repository, > >> which is tested with a v4l2-compliance compiled from the git repo > >> (git://linuxtv.org/v4l-utils.git). > > > > I get one smatch warning: > > > > drivers/staging/media/starfive/camss/stf-isp.c:122 isp_enum_mbus_code() warn: unsigned 'code->index' is never less than zero. > > Could you please tell me the code check command? This way I can use it to check > my next commit. > > > And I also notice that there is no TODO file: staging drivers should have a > > TODO file explaining what needs to be done to get them out of staging. > > OK, I'll add it to my next commit. I previously misunderstood that it was submitted > when moving out of staging. > > > I'm curious to know that as well :-) > > > > It looks like there is a lot of additional development that can be done, since > > most of the ISP parameters appear to be hardcoded. > > Part is the module initialization configuration. In the next stage, we will use > incremental development to implement 3A functions. I'm really looking forward to that part :-) -- Regards, Laurent Pinchart