From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B927CDB483 for ; Wed, 18 Oct 2023 19:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbjJRT1k (ORCPT ); Wed, 18 Oct 2023 15:27:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjJRT1j (ORCPT ); Wed, 18 Oct 2023 15:27:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D330E109; Wed, 18 Oct 2023 12:27:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22244C433C8; Wed, 18 Oct 2023 19:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697657257; bh=1rqOwZjRE1nbagNyIX9i1zuz/F+kupl3lvfqaew4Dl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C+Tu235fFZ9ShVy1YAybs9EPC7bM8MDFacJsq5th4+oYT8RpPrUNEGKRnllQfBjNd tswotbPOIfdrDpHPMfTpCIsSF2Fjzo7dLnS28BR6NqqUjGTNupAWlpBf6EK1oIUAo0 PnYCoah04uvXQ9UbUW/isQiAsUWKJXjrwFucbmZk= Date: Wed, 18 Oct 2023 12:27:36 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Michal =?UTF-8?B?S291dG7DvQ==?= , Johannes Weiner , Shakeel Butt , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Message-Id: <20231018122736.9a2b6abd4f0a1112144503ae@linux-foundation.org> In-Reply-To: References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> <20231004183619.GB39112@cmpxchg.org> <542ggmgjc27yoosxg466c6n4mzcad2z63t3wdbzevzm43g7xlt@5l7qaepzbth6> <4h5uae72ti6jyiibcyfg2bytooy6d6ggtkrgod5a6rmpateyra@4setu5jmd5kn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Oct 2023 10:30:36 -0700 Yosry Ahmed wrote: > On Thu, Oct 5, 2023 at 9:30 AM Michal Koutný wrote: > > > > On Thu, Oct 05, 2023 at 02:31:03AM -0700, Yosry Ahmed wrote: > > > I am not really sure what you mean here. > > > > My "vision" is to treat WORKINGSET_ entries as events. > > That would mean implementing per-node tracking for vm_event_item > > (costlier?). > > That would mean node_stat_item and vm_event_item being effectively > > equal, so they could be merged in one. > > That would be situation to come up with new classification based on use > > cases (e.g. precision/timeliness requirements, state vs change > > semantics). > > > > (Do not take this as blocker of the patch 1/2, I rather used the > > opportunity to discuss a greater possible cleanup.) > > Yeah ideally we can clean this up separately. I would be careful about > userspace exposure though. It seems like CONFIG_VM_EVENT_COUNTERS is > used to control tracking events and displaying them in vmstat, so > moving items between node_stat_item and vm_event_item (or merging > them) won't be easy. I like the word "separately". This series has been in mm-unstable for nearly a month, so I'll move it into mm-stable as-is,