From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F74FCDB483 for ; Wed, 18 Oct 2023 07:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344564AbjJRHkM (ORCPT ); Wed, 18 Oct 2023 03:40:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJRHkJ (ORCPT ); Wed, 18 Oct 2023 03:40:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12DC2B6 for ; Wed, 18 Oct 2023 00:40:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29228C433C7; Wed, 18 Oct 2023 07:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697614807; bh=52gu4uhHVMhD/2inO2iHCSdv7ffG5JVaRL7n7IKgzIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V88jOWnNtotfbOOgqvqTCotxydelHAlUUl284iLp88/HB+ldzp/8igPk2zTn2uCJ6 pEtR5S9WXCHXFS7kwze77ZrIdqmOkTdhgR3n1Sx5gO5BWdUwsw+frIuKCkyAwjofml ihWQZxpS4J0heyaFv8GnMSjccVa8mQFvZWNiYwMY= Date: Wed, 18 Oct 2023 09:40:04 +0200 From: Greg Kroah-Hartman To: Calvince Otieno Cc: gustavo@embeddedor.com, outreachy@lists.linux.dev, Julia Lawall , Martyn Welch , Manohar Vanga , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: fix coding style - remove CamelCasing Message-ID: <2023101841-unglazed-hydration-d6b8@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2023 at 10:22:50AM +0300, Calvince Otieno wrote: > This patch addresses coding style errors identified by checkpatch. The > changes include converting camel case names in constant variables to > UPPERCASE. These changes align with the coding style guidelines. > > > Signed-off-by: Calvince Otieno > --- > drivers/staging/vme_user/vme.h | 12 ++-- > drivers/staging/vme_user/vme_fake.c | 8 +-- > drivers/staging/vme_user/vme_tsi148.c | 88 +++++++++++++-------------- > 3 files changed, 54 insertions(+), 54 deletions(-) > > diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h > index fbcbd0204453..0b40859fee23 100644 > --- a/drivers/staging/vme_user/vme.h > +++ b/drivers/staging/vme_user/vme.h > @@ -33,13 +33,13 @@ enum vme_resource_type { > #define VME_SCT 0x1 > #define VME_BLT 0x2 > #define VME_MBLT 0x4 > -#define VME_2eVME 0x8 > -#define VME_2eSST 0x10 > -#define VME_2eSSTB 0x20 > +#define VME_2EVME 0x8 > +#define VME_2ESST 0x10 > +#define VME_2ESSTB 0x20 Checkpatch is wrong here, this should stay as-is. thanks, greg k-h