From: Steven Rostedt <rostedt@goodmis.org>
To: kernel test robot <lkp@intel.com>
Cc: Tom Zanussi <zanussi@kernel.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: kernel/trace/trace_kprobe.c:952: warning: Excess function parameter 'args' description in '__kprobe_event_gen_cmd_start'
Date: Thu, 19 Oct 2023 09:22:07 -0400 [thread overview]
Message-ID: <20231019092207.7d2fa545@gandalf.local.home> (raw)
In-Reply-To: <202310190437.paI6LYJF-lkp@intel.com>
On Thu, 19 Oct 2023 04:33:41 +0800
kernel test robot <lkp@intel.com> wrote:
> All warnings (new ones prefixed by >>):
>
> >> kernel/trace/trace_kprobe.c:952: warning: Excess function parameter 'args' description in '__kprobe_event_gen_cmd_start'
> >> kernel/trace/trace_kprobe.c:1017: warning: Excess function parameter 'args' description in '__kprobe_event_add_fields'
>
>
> vim +952 kernel/trace/trace_kprobe.c
>
> 929
> 930 /**
> 931 * __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
> 932 * @cmd: A pointer to the dynevent_cmd struct representing the new event
> 933 * @name: The name of the kprobe event
> 934 * @loc: The location of the kprobe event
> 935 * @kretprobe: Is this a return probe?
> 936 * @args: Variable number of arg (pairs), one pair for each field
> 937 *
> 938 * NOTE: Users normally won't want to call this function directly, but
> 939 * rather use the kprobe_event_gen_cmd_start() wrapper, which automatically
> 940 * adds a NULL to the end of the arg list. If this function is used
> 941 * directly, make sure the last arg in the variable arg list is NULL.
> 942 *
> 943 * Generate a kprobe event command to be executed by
> 944 * kprobe_event_gen_cmd_end(). This function can be used to generate the
> 945 * complete command or only the first part of it; in the latter case,
> 946 * kprobe_event_add_fields() can be used to add more fields following this.
> 947 *
> 948 * Return: 0 if successful, error otherwise.
> 949 */
> 950 int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
> 951 const char *name, const char *loc, ...)
> > 952 {
So what is the proper kerneldoc way to express variable length arguments?
-- Steve
next prev parent reply other threads:[~2023-10-19 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 20:33 kernel test robot
2023-10-19 13:22 ` Steven Rostedt [this message]
2023-10-27 5:19 ` Yujie Liu
2023-10-28 21:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019092207.7d2fa545@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®