From: Roman Gushchin <roman.gushchin@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Dennis Zhou <dennis@kernel.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current()
Date: Thu, 19 Oct 2023 15:53:46 -0700 [thread overview]
Message-ID: <20231019225346.1822282-7-roman.gushchin@linux.dev> (raw)
In-Reply-To: <20231019225346.1822282-1-roman.gushchin@linux.dev>
Reimplement get_obj_cgroup_from_current() using current_obj_cgroup().
get_obj_cgroup_from_current() and current_obj_cgroup() share 80% of
the code, so the new implementation is almost trivial.
get_obj_cgroup_from_current() is a convenient function used by the
bpf subsystem, so there is no reason to get rid of it completely.
Signed-off-by: Roman Gushchin (Cruise) <roman.gushchin@linux.dev>
---
include/linux/memcontrol.h | 11 ++++++++++-
mm/memcontrol.c | 32 --------------------------------
2 files changed, 10 insertions(+), 33 deletions(-)
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index a89df289144d..ef26551a633f 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -1778,9 +1778,18 @@ void __memcg_kmem_uncharge_page(struct page *page, int order);
* needs to be used outside of the local scope.
*/
struct obj_cgroup *current_obj_cgroup(void);
-struct obj_cgroup *get_obj_cgroup_from_current(void);
struct obj_cgroup *get_obj_cgroup_from_folio(struct folio *folio);
+static inline struct obj_cgroup *get_obj_cgroup_from_current(void)
+{
+ struct obj_cgroup *objcg = current_obj_cgroup();
+
+ if (objcg)
+ obj_cgroup_get(objcg);
+
+ return objcg;
+}
+
int obj_cgroup_charge(struct obj_cgroup *objcg, gfp_t gfp, size_t size);
void obj_cgroup_uncharge(struct obj_cgroup *objcg, size_t size);
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e3d4b7fabb7d..e13c10912c16 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3056,38 +3056,6 @@ static struct obj_cgroup *current_objcg_update(void)
return objcg;
}
-__always_inline struct obj_cgroup *get_obj_cgroup_from_current(void)
-{
- struct mem_cgroup *memcg;
- struct obj_cgroup *objcg;
-
- if (in_task()) {
- memcg = current->active_memcg;
- if (unlikely(memcg))
- goto from_memcg;
-
- objcg = READ_ONCE(current->objcg);
- if (unlikely((unsigned long)objcg & CURRENT_OBJCG_UPDATE_FLAG))
- objcg = current_objcg_update();
-
- if (objcg) {
- obj_cgroup_get(objcg);
- return objcg;
- }
- } else {
- memcg = this_cpu_read(int_active_memcg);
- if (unlikely(memcg))
- goto from_memcg;
- }
- return NULL;
-
-from_memcg:
- rcu_read_lock();
- objcg = __get_obj_cgroup_from_memcg(memcg);
- rcu_read_unlock();
- return objcg;
-}
-
__always_inline struct obj_cgroup *current_obj_cgroup(void)
{
struct mem_cgroup *memcg;
--
2.42.0
next prev parent reply other threads:[~2023-10-19 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 22:53 [PATCH v5 0/6] mm: improve performance of accounted kernel memory allocations Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 1/6] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 2/6] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2023-10-20 5:33 ` Vlastimil Babka
2023-10-19 22:53 ` [PATCH v5 3/6] mm: kmem: make memcg keep a reference to the original objcg Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 4/6] mm: kmem: scoped objcg protection Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 5/6] percpu: " Roman Gushchin
2023-10-19 22:53 ` Roman Gushchin [this message]
2023-10-20 5:41 ` [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current() Vlastimil Babka
2023-10-20 6:31 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019225346.1822282-7-roman.gushchin@linux.dev \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®