From: Su Hui <suhui@nfschina.com>
To: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org,
benjamin.tissoires@redhat.com
Cc: Su Hui <suhui@nfschina.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] HID: wacom_sys: add error code check in wacom_feature_mapping
Date: Fri, 20 Oct 2023 17:02:38 +0800 [thread overview]
Message-ID: <20231020090237.201029-1-suhui@nfschina.com> (raw)
hid_report_raw_event() can return error code like '-ENOMEM' if
failed, so check 'ret' to make sure all things work fine.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/hid/wacom_sys.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 3f704b8072e8..1f898d4ee708 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -320,6 +320,8 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n && features->type == HID_GENERIC) {
ret = hid_report_raw_event(hdev,
HID_FEATURE_REPORT, data, n, 0);
+ if (ret)
+ hid_warn(hdev, "failed to report feature\n");
} else if (ret == 2 && features->type != HID_GENERIC) {
features->touch_max = data[1];
} else {
@@ -381,6 +383,8 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n) {
ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT,
data, n, 0);
+ if (ret)
+ hid_warn(hdev, "failed to report feature\n");
} else {
hid_warn(hdev, "%s: could not retrieve sensor offsets\n",
__func__);
--
2.30.2
next reply other threads:[~2023-10-20 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:02 Su Hui [this message]
2023-11-06 3:57 ` Rahul Rameshbabu
2023-11-06 5:50 ` Su Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020090237.201029-1-suhui@nfschina.com \
--to=suhui@nfschina.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®