From: Syed Saba Kareem <Syed.SabaKareem@amd.com>
To: <broonie@kernel.org>, <alsa-devel@alsa-project.org>
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, mario.limonciello@amd.com,
venkataprasad.potturu@amd.com, arungopal.kondaveeti@amd.com,
mastan.katragadda@amd.com, juan.martinez@amd.com,
"Syed Saba Kareem" <Syed.SabaKareem@amd.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Yang Li" <yang.lee@linux.alibaba.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: [PATCH 08/13] ASoC: amd: acp: add condition check for i2s clock generation
Date: Sat, 21 Oct 2023 20:20:49 +0530 [thread overview]
Message-ID: <20231021145110.478744-8-Syed.SabaKareem@amd.com> (raw)
In-Reply-To: <20231021145110.478744-1-Syed.SabaKareem@amd.com>
for only PDM endpoint i2s master clock is not required.
Add a condition check for the same based on chip flag value.
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
---
sound/soc/amd/acp/acp-rembrandt.c | 12 ++++++++++--
sound/soc/amd/acp/acp63.c | 12 ++++++++----
2 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/sound/soc/amd/acp/acp-rembrandt.c b/sound/soc/amd/acp/acp-rembrandt.c
index ef5fe6438efd..158f819f8da4 100644
--- a/sound/soc/amd/acp/acp-rembrandt.c
+++ b/sound/soc/amd/acp/acp-rembrandt.c
@@ -191,6 +191,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)
struct acp_chip_info *chip;
struct acp_dev_data *adata;
struct resource *res;
+ u32 ret;
chip = dev_get_platdata(&pdev->dev);
if (!chip || !chip->base) {
@@ -234,7 +235,12 @@ static int rembrandt_audio_probe(struct platform_device *pdev)
acp_machine_select(adata);
dev_set_drvdata(dev, adata);
- acp6x_master_clock_generate(dev);
+
+ if (chip->flag != FLAG_AMD_LEGACY_ONLY_DMIC) {
+ ret = acp6x_master_clock_generate(dev);
+ if (ret)
+ return ret;
+ }
acp_enable_interrupts(adata);
acp_platform_register(dev);
pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
@@ -263,7 +269,9 @@ static int __maybe_unused rmb_pcm_resume(struct device *dev)
snd_pcm_uframes_t buf_in_frames;
u64 buf_size;
- acp6x_master_clock_generate(dev);
+ if (adata->flag != FLAG_AMD_LEGACY_ONLY_DMIC)
+ acp6x_master_clock_generate(dev);
+
spin_lock(&adata->acp_lock);
list_for_each_entry(stream, &adata->stream_list, list) {
substream = stream->substream;
diff --git a/sound/soc/amd/acp/acp63.c b/sound/soc/amd/acp/acp63.c
index 0cec6ecaadfa..b871a216a6af 100644
--- a/sound/soc/amd/acp/acp63.c
+++ b/sound/soc/amd/acp/acp63.c
@@ -244,10 +244,12 @@ static int acp63_audio_probe(struct platform_device *pdev)
adata->machines = snd_soc_acpi_amd_acp63_acp_machines;
acp_machine_select(adata);
dev_set_drvdata(dev, adata);
- ret = acp63_i2s_master_clock_generate(adata);
- if (ret)
- return ret;
+ if (chip->flag != FLAG_AMD_LEGACY_ONLY_DMIC) {
+ ret = acp63_i2s_master_clock_generate(adata);
+ if (ret)
+ return ret;
+ }
acp_enable_interrupts(adata);
acp_platform_register(dev);
pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
@@ -276,7 +278,9 @@ static int __maybe_unused acp63_pcm_resume(struct device *dev)
snd_pcm_uframes_t buf_in_frames;
u64 buf_size;
- acp63_i2s_master_clock_generate(adata);
+ if (adata->flag != FLAG_AMD_LEGACY_ONLY_DMIC)
+ acp63_i2s_master_clock_generate(adata);
+
spin_lock(&adata->acp_lock);
list_for_each_entry(stream, &adata->stream_list, list) {
if (stream) {
--
2.25.1
next prev parent reply other threads:[~2023-10-21 14:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 14:50 [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 02/13] ASoC: amd: acp: refactor acp i2s clock generation code Syed Saba Kareem
2023-10-23 7:37 ` Amadeusz Sławiński
2023-10-21 14:50 ` [PATCH 03/13] ASoC: amd: acp: add i2s clock generation support for acp6.3 based platforms Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 04/13] ASoC: amd: acp: add machine driver support for acp6.3 platform Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 05/13] ASoC: amd: acp: add Kconfig options for acp6.3 based platform driver Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 06/13] ASoC: amd: acp: add code for scanning acp pdm controller Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 07/13] ASoC: amd: acp: add platform and flag data to acp data structure Syed Saba Kareem
2023-10-21 14:50 ` Syed Saba Kareem [this message]
2023-10-21 14:50 ` [PATCH 09/13] ASoC: amd: acp: add machine driver support for pdm use case Syed Saba Kareem
2023-10-27 8:49 ` Krzysztof Kozlowski
[not found] ` <3ec97548-1f91-49d0-adfb-4f8051ca9a97@amd.com>
[not found] ` <f8f8017c-4e76-4d70-918f-d7cb45186184@kernel.org>
[not found] ` <c0ea139c-9861-4ea1-b547-6e3c380301b3@amd.com>
[not found] ` <ZTvkCAYsrS62/82u@finisterre.sirena.org.uk>
2023-10-27 17:32 ` syed saba kareem
2023-10-28 9:14 ` Krzysztof Kozlowski
2023-10-21 14:50 ` [PATCH 10/13] ASoC: amd: acp: change acp-deinit function arguments Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 11/13] ASoC: amd: acp: change acp power on mask macro value Syed Saba Kareem
2023-10-21 14:50 ` [PATCH 12/13] ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform Syed Saba Kareem
2023-10-23 7:50 ` Amadeusz Sławiński
2023-10-26 10:04 ` syed saba kareem
2023-10-21 14:50 ` [PATCH 13/13] ASoC: amd: acp: add machine driver support for acp7.0 Syed Saba Kareem
2023-10-23 8:01 ` [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support Krzysztof Kozlowski
[not found] ` <12c8c0f3-8364-4f25-976e-8cca29b5e17f@amd.com>
2023-10-26 15:00 ` Krzysztof Kozlowski
2023-10-25 16:50 ` Mark Brown
2023-10-26 9:44 ` syed saba kareem
2023-10-26 15:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231021145110.478744-8-Syed.SabaKareem@amd.com \
--to=syed.sabakareem@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arungopal.kondaveeti@amd.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=juan.martinez@amd.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mastan.katragadda@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=venkataprasad.potturu@amd.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®