From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6818C00A8F for ; Mon, 23 Oct 2023 23:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231506AbjJWXkJ (ORCPT ); Mon, 23 Oct 2023 19:40:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbjJWXkG (ORCPT ); Mon, 23 Oct 2023 19:40:06 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7797DDE for ; Mon, 23 Oct 2023 16:40:04 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5a7ac9c1522so55065837b3.0 for ; Mon, 23 Oct 2023 16:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698104403; x=1698709203; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=6neP5ivK010SBRb0ibXYexUf8ZRbqIGhikwLVX47+yQ=; b=xbElmHYFUhnIKBFb6so2aaj7in7ozZtHvbYUpgx1aq3YoHjpTd8sG3hqvzY+bwCcNC 4zRIToRxvLzRG0ZRm6wTGa2fN9onLLWvJQOq12rq30fLGyulz46Lff4YJPLQ597aGPVP IrV9BY0JrNe0CPMTMTFkLtB1impi99Xz7gZRQSWTgNKRPEDUQUL9dCaA6zrWzrqrIC4A 2mYNECP2cXguTNKmCde19jxMVo96p7CY5mbjxlgq3Oyan3zUduTUH85NxJCJMQqUhAQ+ 0mBE98r2YCX61pK9Y1LIHj2TaNadJ5rnL15/Fdy/0YfIbuQ2TLfHyekF0W7gdcCj+z+P eB1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698104403; x=1698709203; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6neP5ivK010SBRb0ibXYexUf8ZRbqIGhikwLVX47+yQ=; b=aCT2gRjRzTjFy+Gb7nfqANdG0hPmzudRkgUUccf+Oc3xJLb2kh4WkcqN9HlmVi1/6g 2xeZVxFq1v9Ty8NM9Kg8zy8DuuSz+5resCUMZp0ablmafMrSgNIBBqKbQwPxgUdcpLZZ dcP/eK2SPhceDhTiKaRBx3TQ6pcPsUbLXU/+CpNpa4CAbb9tZopctOYQlMXoN9C6vQsj E0PGVFVTS0W9dbvV2vnXBcPvlUvA81UBn0ireftk6JNbwip4sK/WloI+ITadETC0Mjjx RF1S5/Y/j6HN1FOXBxldmNn88dPh4grxvN6GR42clznlfb/Z+9uGJyyOUm7t4Wc0MFpM HJAQ== X-Gm-Message-State: AOJu0YxOS9RtBrpsXmK2iV1whZuTDZd/0SrO8Nfm6y/MHnN+BtdltADg +cJTR+4v2QEijIx39OlrBrCQwkb/pBc= X-Google-Smtp-Source: AGHT+IGZphk2LvJvNpVHYe9/KXoI/Dz3HTFp02JVRm24AJP58EGDg5NlbGnP028g0rTzqiiIYaCkkczfT9g= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d50f:0:b0:59b:c811:a702 with SMTP id x15-20020a0dd50f000000b0059bc811a702mr237963ywd.6.1698104403721; Mon, 23 Oct 2023 16:40:03 -0700 (PDT) Reply-To: Sean Christopherson Date: Mon, 23 Oct 2023 16:39:54 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.758.gaed0368e0e-goog Message-ID: <20231023234000.2499267-1-seanjc@google.com> Subject: [PATCH 0/6] KVM: x86/pmu: Clean up emulated PMC event handling From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , Roman Kagan , Jim Mattson , Dapeng Mi , Like Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ultimate goal of this series is to track emulated counter events using a dedicated variable instead of trying to track the previous counter value. Tracking the previous counter value is flawed as it takes a snapshot at every emulated event, but only checks for overflow prior to VM-Enter, i.e. KVM could miss an overflow if KVM ever supports emulating event types that can occur multiple times in a single VM-Exit. Patches 1-5 are (some loosely, some tightly) related fixes and cleanups to simplify the emulated counter approach implementation. The fixes are tagged for stable as usersepace could cause some weirdness around perf events, but I doubt any real world VMM is actually affected. Sean Christopherson (6): KVM: x86/pmu: Move PMU reset logic to common x86 code KVM: x86/pmu: Reset the PMU, i.e. stop counters, before refreshing KVM: x86/pmu: Stop calling kvm_pmu_reset() at RESET (it's redundant) KVM: x86/pmu: Remove manual clearing of fields in kvm_pmu_init() KVM: x86/pmu: Update sample period in pmc_write_counter() KVM: x86/pmu: Track emulated counter events instead of previous counter arch/x86/include/asm/kvm-x86-pmu-ops.h | 2 +- arch/x86/include/asm/kvm_host.h | 17 +++- arch/x86/kvm/pmu.c | 128 +++++++++++++++++++++---- arch/x86/kvm/pmu.h | 47 +-------- arch/x86/kvm/svm/pmu.c | 17 ---- arch/x86/kvm/vmx/pmu_intel.c | 22 ----- arch/x86/kvm/x86.c | 1 - 7 files changed, 127 insertions(+), 107 deletions(-) base-commit: ec2f1daad460c6201338dae606466220ccaa96d5 -- 2.42.0.758.gaed0368e0e-goog