From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB42C25B67 for ; Tue, 24 Oct 2023 00:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbjJXAwc (ORCPT ); Mon, 23 Oct 2023 20:52:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbjJXAwa (ORCPT ); Mon, 23 Oct 2023 20:52:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DA08D79 for ; Mon, 23 Oct 2023 17:52:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D204C433C7; Tue, 24 Oct 2023 00:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698108747; bh=Cz2C33V7rW5mFx+/r38YL53PClSvAQtbG3qbhk9hvAs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rDYX/pqMphrx0x16wq56T8zNqw7D87iDLbydIUAmF//YqfycSHqDKdN7izTfqM6u1 5RgwT9aKniQfjiJ0FyyTTqy2CqREwu35OHcIxwcCNX4CvCnS6cmMVDfmZYI0TRQzeG xs9oL8ml/6eM0p8qVv22KpmipXzV2mZ3T/vklDS1zwNT7VUaltF5lYf5RNFwpywm3i 92gji/oLrkEkp73Ap3oG1ae4CNbijzSvO3CLnyWokBzJMBtLcSm20unvJMB9NBjwY4 kRgH1quN43rR+7s5+Axr74sFrjTBNzsOukVDrdJRlKPpZfpn5v+ibIg14951EYPaic lXpgjgYS0QoSQ== Date: Tue, 24 Oct 2023 09:52:21 +0900 From: Masami Hiramatsu (Google) To: "wuqiang.matt" Cc: linux-trace-kernel@vger.kernel.org, davem@davemloft.net, anil.s.keshavamurthy@intel.com, naveen.n.rao@linux.ibm.com, rostedt@goodmis.org, peterz@infradead.org, akpm@linux-foundation.org, sander@svanheule.net, ebiggers@google.com, dan.j.williams@intel.com, jpoimboe@kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, mattwu@163.com Subject: Re: [PATCH v1] kprobes: unused header files removed Message-Id: <20231024095221.4a9ab55c6bd3abd875f0ac08@kernel.org> In-Reply-To: <20231023112245.6112-1-wuqiang.matt@bytedance.com> References: <20231023112245.6112-1-wuqiang.matt@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Oct 2023 19:22:45 +0800 "wuqiang.matt" wrote: > As kernel test robot reported, lib/test_objpool.c (trace:probes/for-next) > has linux/version.h included, but version.h is not used at all. Then more > unused headers are found in test_objpool.c and rethook.c, and all of them > should be removed. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202310191512.vvypKU5Z-lkp@intel.com/ Looks good to me. Acked-by: Masami Hiramatsu (Google) Thanks, > > Signed-off-by: wuqiang.matt > --- > kernel/trace/rethook.c | 2 -- > lib/test_objpool.c | 6 ------ > 2 files changed, 8 deletions(-) > > diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c > index 13c8e6773892..6fd7d4ecbbc6 100644 > --- a/kernel/trace/rethook.c > +++ b/kernel/trace/rethook.c > @@ -8,8 +8,6 @@ > #include > #include > #include > -#include > -#include > > /* Return hook list (shadow stack by list) */ > > diff --git a/lib/test_objpool.c b/lib/test_objpool.c > index 98b5b37b6eea..a94078402138 100644 > --- a/lib/test_objpool.c > +++ b/lib/test_objpool.c > @@ -6,21 +6,15 @@ > * Copyright: wuqiang.matt@bytedance.com > */ > > -#include > #include > #include > #include > -#include > -#include > #include > #include > -#include > -#include > #include > #include > #include > #include > -#include > #include > > #define OT_NR_MAX_BULK (16) > -- > 2.40.1 > -- Masami Hiramatsu (Google)