From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C12C25B6D for ; Wed, 25 Oct 2023 14:26:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344999AbjJYO0H (ORCPT ); Wed, 25 Oct 2023 10:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344979AbjJYOZ7 (ORCPT ); Wed, 25 Oct 2023 10:25:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FEB310D0; Wed, 25 Oct 2023 07:25:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37487C433C8; Wed, 25 Oct 2023 14:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698243954; bh=0F8pJ3JqD7QlDe970Bdf1JSfOPxON3UsNUeHODnd4qY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZYytXJVtroW9Bh/zSmBleWnhZEnKL5nQHkCgbGllp3YHDRdRWTLo77EA/A+wcVwF+ SqEgyHVox1D7iTJxtH8BqOVlqu8aQNLshaQIstfxlVKugWzbWxLJTom1ibUlcdAe9e hNGo1hkLwx24+tiHFXvSZxXFHFoNwNKQ772otSTQGtBkOywVPtS7M4C2tIcmKg/I6d ruojPi/QQljmx4+S66Xv0QTe8REr5QD6Zk3gdnMoydG79uJNC3Y3b+O/BWyz8ii5O8 E7NCM3hLAeAc7NaTJnkbq0msdIgbKADpXab8QTEqP/IE4/EZibF4FFdJ8xaQt8xMz7 2z8HJZDORZ0gA== Date: Wed, 25 Oct 2023 15:25:47 +0100 From: Conor Dooley To: Krzysztof Kozlowski Cc: Richard Leitner , Guenter Roeck , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: hwmon: add ti,ina238 Message-ID: <20231025-epilogue-preset-962b88985ea3@spud> References: <20231025-ina237-v1-0-a0196119720c@linux.dev> <20231025-ina237-v1-2-a0196119720c@linux.dev> <20231025-hut-omnivore-f4b44a7b928d@spud> <20231025-eatery-backup-ad85c043cb01@spud> <8cd5c34e-f733-445d-bc1e-d4dea1bcb47d@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xrjRwLJD5GJJAX7+" Content-Disposition: inline In-Reply-To: <8cd5c34e-f733-445d-bc1e-d4dea1bcb47d@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xrjRwLJD5GJJAX7+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 25, 2023 at 04:18:31PM +0200, Krzysztof Kozlowski wrote: > On 25/10/2023 16:11, Conor Dooley wrote: > > On Wed, Oct 25, 2023 at 04:07:31PM +0200, Richard Leitner wrote: > >> On Wed, Oct 25, 2023 at 03:00:01PM +0100, Conor Dooley wrote: > >>> On Wed, Oct 25, 2023 at 10:34:12AM +0000, Richard Leitner wrote: > >>>> The ina238 driver is available since 2021 but lacks a dt-bindings fi= le. > >>>> Therefore add the missing file now. > >>> > >>> Seemingly it is documented in Documentation/devicetree/bindings/hwmon= /ti,ina2xx.yaml > >> > >> Thanks for the feedback. True. So is it fine if it's left there or > >> should it be removed from ti,ina2xxx.yml as this is a separate driver > >> with different properties? > >=20 > > Merging them would seem like the most straightforward thing to do, no? >=20 > Sorry folks, I don't quite get what do you want to merge or move and > why. Drivers are not related to bindings. The point is the compatible is > already documented, so is anything wrong with existing documentation? If it was not clear, I meant merging the bindings, not the drivers. IOW, adding the new compatible for the ina237 to the existing ina2xx.yaml binding. --xrjRwLJD5GJJAX7+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTklawAKCRB4tDGHoIJi 0kTMAP0Q3flehQeFG8GrnHx6b6bEYhSUfIi6uz259MhiOKJgZgD/U+SEhmFR365g iAJsSG9ggcCuvoJRqFkUk7LG4poyjQU= =T4Tm -----END PGP SIGNATURE----- --xrjRwLJD5GJJAX7+--