From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Willem de Bruijn <willemb@google.com>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
Simon Horman <horms@kernel.org>,
Justin Chen <justin.chen@broadcom.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Joe Damato <jdamato@fastly.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Jiri Pirko <jiri@resnulli.us>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next v2 0/5] WAKE_FILTER for Broadcom PHY (v2)
Date: Thu, 26 Oct 2023 15:45:04 -0700 [thread overview]
Message-ID: <20231026224509.112353-1-florian.fainelli@broadcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]
This is a re-submission of the series that was submitted before:
https://lore.kernel.org/all/20230516231713.2882879-1-florian.fainelli@broadcom.com/
A number of things have changed:
- there is proper fallback between the PHY and the MAC now, whereas
before we would abort right away due to -EOPNOTSUPP
- added support for programming the Ethernet type for matching
- fixed reporting of masks via ethtool
- added proper validation of RX_CLS_LOC_ANY/RX_CLS_LOC_FIRST and
location
- addressed feedback given by Andrew by validating that we have at least
one RX_CLS_FLOW_WAKE filter programmed to allow enabling WAKE_FILTER
via ethtool, otherwise we will not wake-up from WAKE_FILTER
- use a PHY register as a scratchpad to accurately report whether a
custom filter was installed, before that we would falsely report
WAKE_UCAST/BCAST/MCAST but not WAKE_FILTER upon cold boot
- corrected commit message to be accurate (MAC address did not match the
IPv4 address in the example)
Changes in v2:
- corrected sparse annotationes for h_proto (Vincent)
- added 2 spaces for commands in commit messages (Vincent)
- added hunk in patch 5 back into patch 4 (self)
Florian Fainelli (5):
net: ethtool: Make RXNFC walking code accept a callback
net: ethtool: Add validation for WAKE_FILTER
net: phy: Add pluming for ethtool_{get,set}_rxnfc
net: phy: broadcom: Add support for WAKE_FILTER
net: bcmgenet: Interrogate PHY for WAKE_FILTER programming
.../net/ethernet/broadcom/genet/bcmgenet.c | 16 ++
drivers/net/phy/bcm-phy-lib.c | 205 +++++++++++++++++-
drivers/net/phy/bcm-phy-lib.h | 5 +
drivers/net/phy/broadcom.c | 2 +
drivers/net/phy/phy.c | 19 ++
include/linux/phy.h | 8 +
net/ethtool/common.c | 96 +++++++-
net/ethtool/common.h | 3 +
net/ethtool/ioctl.c | 3 +
net/ethtool/wol.c | 3 +
10 files changed, 350 insertions(+), 10 deletions(-)
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next reply other threads:[~2023-10-26 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 22:45 Florian Fainelli [this message]
2023-10-26 22:45 ` [PATCH net-next v2 1/5] net: ethtool: Make RXNFC walking code accept a callback Florian Fainelli
2023-10-26 23:18 ` Jacob Keller
2023-10-26 22:45 ` [PATCH net-next v2 2/5] net: ethtool: Add validation for WAKE_FILTER Florian Fainelli
2023-10-26 23:19 ` Jacob Keller
2023-10-26 22:45 ` [PATCH net-next v2 3/5] net: phy: Add pluming for ethtool_{get,set}_rxnfc Florian Fainelli
2023-10-26 23:20 ` Jacob Keller
2023-10-26 23:32 ` Florian Fainelli
2023-10-27 2:53 ` Jakub Kicinski
2023-10-26 22:45 ` [PATCH net-next v2 4/5] net: phy: broadcom: Add support for WAKE_FILTER Florian Fainelli
2023-10-26 23:22 ` Jacob Keller
2023-10-26 22:45 ` [PATCH net-next v2 5/5] net: bcmgenet: Interrogate PHY for WAKE_FILTER programming Florian Fainelli
2023-10-26 23:23 ` Jacob Keller
2023-10-26 23:52 ` Florian Fainelli
[not found] ` <6456509b-9df7-47e3-b941-c307594a80d2@intel.com>
2023-10-27 17:15 ` Florian Fainelli
2023-10-27 17:36 ` Jacob Keller
2023-10-27 18:31 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026224509.112353-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=tariqt@nvidia.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®