From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A084C25B48 for ; Fri, 27 Oct 2023 19:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbjJ0TDG (ORCPT ); Fri, 27 Oct 2023 15:03:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231461AbjJ0TDE (ORCPT ); Fri, 27 Oct 2023 15:03:04 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98947B0; Fri, 27 Oct 2023 12:03:02 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-66cfef11a25so15868276d6.3; Fri, 27 Oct 2023 12:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698433381; x=1699038181; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/Io45bblugk6GHU86iMBX0jRVvZ5htGOKZIfVTPVwXE=; b=C7OFYN20Z7RnqjfrVa1aHuHPo9it8iC+l+AX/m64I7ZSyu+z9dvXEM4wlNpK83KJhs 3Onz9N6BbRN6CjVim3MNg++oNV3SEIpIV3jCATSpklqPYFRANOkzjhOoK1C7PfiXwQII YijO0MH6VNlk7fhcuObrDddqs8+WHYytAgDfb0vFyRRqCLUa3tTxyVohbDi9AtoY3mxp dlFfuFCKeBs3xwA23p8rQuhBdXRQ/pK67yYyvsO1IaIzgTAEAk/WfKGzyDqNaIt78x/Q phKc/5Suqze+QnmXCbixQR8YUatrmO4rxte0//AJvo3CcbbHWK6DEvMEUFfWBhlnqwrS ga2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698433381; x=1699038181; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Io45bblugk6GHU86iMBX0jRVvZ5htGOKZIfVTPVwXE=; b=MTQ+abfI55fcdIdqM7hU8FtzAoeCYp2dEMuU4tyogMKgofd6eS4i7I+KHTJF8WYi6A RBbT70ralyB2Xjngd2ouV5mBzoNHye0qt22YZmhJKsfjBl86azDriSUR4yhpjqEXKS49 8zr+DehAaoVMlZLvMUh4usOihYaRP+suVs0Lrx/nUEDLL/StGLRHvD4qzUVFohHlr3ox eIeK/2iq9EvRbU4lVKsbPNpT2ZDzzgvpj0EZE6bHwgWLkv4arMaVWv0G8UmIJBuOqdPt GkJbORmJT5zCoMvxE+nyIzuD0AYsjms7wjx+TuyzG9o8uEue040avX0p9Tc+2a2t45ac lQng== X-Gm-Message-State: AOJu0YzCXwAbrmleO59bnKw8MSPs4QxZDQi6bM/cXzvc4kyZ31DLGBvr 5PbPWGHUmIgVQODXde9+HTappZiyCA== X-Google-Smtp-Source: AGHT+IHfYJEilVaXWDYjxblIhjiDRowZ6QCyhiNfjv4ef2Fxjo2bamCtWSGzTr57wERF8ldHGodJ9Q== X-Received: by 2002:a05:6214:c49:b0:66d:9589:6bb6 with SMTP id r9-20020a0562140c4900b0066d95896bb6mr4058302qvj.63.1698433381324; Fri, 27 Oct 2023 12:03:01 -0700 (PDT) Received: from n191-129-154.byted.org ([147.160.184.150]) by smtp.gmail.com with ESMTPSA id ph4-20020a0562144a4400b0066da90f0c19sm844422qvb.24.2023.10.27.12.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 12:03:00 -0700 (PDT) Date: Fri, 27 Oct 2023 19:02:59 +0000 From: Peilin Ye To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jesper Dangaard Brouer Cc: Peilin Ye , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Cong Wang , Jiang Wang , Youlun Zhang Subject: Re: [PATCH net] veth: Fix RX stats for bpf_redirect_peer() traffic Message-ID: <20231027190254.GA88444@n191-129-154.byted.org> References: <20231027184657.83978-1-yepeilin.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027184657.83978-1-yepeilin.cs@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Fri, Oct 27, 2023 at 06:46:57PM +0000, Peilin Ye wrote: > diff --git a/net/core/filter.c b/net/core/filter.c > index 21d75108c2e9..7aca28b7d0fd 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -2492,6 +2492,7 @@ int skb_do_redirect(struct sk_buff *skb) > net_eq(net, dev_net(dev)))) > goto out_drop; > skb->dev = dev; > + dev_sw_netstats_rx_add(dev, skb->len); This assumes that all devices that support BPF_F_PEER (currently only veth) use tstats (instead of lstats, or dstats) - is that okay? If not, should I add another NDO e.g. ->ndo_stats_rx_add()? Thanks, Peilin Ye