From: Brett Creeley <brett.creeley@amd.com>
To: <jgg@ziepe.ca>, <yishaih@nvidia.com>,
<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
<alex.williamson@redhat.com>, <dan.carpenter@linaro.org>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<brett.creeley@amd.com>, <shannon.nelson@amd.com>
Subject: [PATCH v3 vfio 0/3] pds/vfio: Fixes for locking bugs
Date: Fri, 27 Oct 2023 15:36:48 -0700 [thread overview]
Message-ID: <20231027223651.36047-1-brett.creeley@amd.com> (raw)
This series contains fixes for locking bugs in the recently introduced
pds-vfio-pci driver. There was an initial bug reported by Dan Carpenter
at:
https://lore.kernel.org/kvm/1f9bc27b-3de9-4891-9687-ba2820c1b390@moroto.mountain/
However, more locking bugs were found when looking into the previously
mentioned issue. So, all fixes are included in this series.
v3:
- Change reset lock from spinlock to mutex
v2:
https://lore.kernel.org/kvm/20231011230115.35719-1-brett.creeley@amd.com/
- Trim the OOPs in the patch commit messages
- Rework patch 3/3 to only unlock the spinlock once
- Destroy the state_mutex in the driver specific vfio_device_ops.release
callback
v1:
https://lore.kernel.org/kvm/20230914191540.54946-1-brett.creeley@amd.com/
Brett Creeley (3):
pds/vfio: Fix spinlock bad magic BUG
pds/vfio: Fix mutex lock->magic != lock warning
pds/vfio: Fix possible sleep while in atomic context
drivers/vfio/pci/pds/pci_drv.c | 4 ++--
drivers/vfio/pci/pds/vfio_dev.c | 30 +++++++++++++++++++++---------
drivers/vfio/pci/pds/vfio_dev.h | 2 +-
3 files changed, 24 insertions(+), 12 deletions(-)
--
2.17.1
next reply other threads:[~2023-10-27 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 22:36 Brett Creeley [this message]
2023-10-27 22:36 ` [PATCH v3 vfio 1/3] pds/vfio: Fix spinlock bad magic BUG Brett Creeley
2023-10-31 6:13 ` Tian, Kevin
2023-11-01 19:18 ` Brett Creeley
2023-10-27 22:36 ` [PATCH v3 vfio 2/3] pds/vfio: Fix mutex lock->magic != lock warning Brett Creeley
2023-10-27 22:36 ` [PATCH v3 vfio 3/3] pds/vfio: Fix possible sleep while in atomic context Brett Creeley
2023-10-31 6:14 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027223651.36047-1-brett.creeley@amd.com \
--to=brett.creeley@amd.com \
--cc=alex.williamson@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shannon.nelson@amd.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®