From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94955C4332F for ; Sun, 29 Oct 2023 13:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbjJ2NOQ (ORCPT ); Sun, 29 Oct 2023 09:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjJ2NOO (ORCPT ); Sun, 29 Oct 2023 09:14:14 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E85BABC for ; Sun, 29 Oct 2023 06:14:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F4D7C433C8; Sun, 29 Oct 2023 13:14:10 +0000 (UTC) Date: Sun, 29 Oct 2023 09:14:08 -0400 From: Steven Rostedt To: Naresh Kamboju Cc: LKML , Linux trace kernel , Masami Hiramatsu , Mark Rutland , Arnd Bergmann , "Naresh Kamboju , Beau Belgrave , Ajay Kaher , Andrew Morton" , lkft-triage@lists.linaro.org Subject: Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry Message-ID: <20231029091408.0179cee4@rorschach.local.home> In-Reply-To: References: <20231028164650.4f5ea18a@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Oct 2023 12:31:54 +0530 Naresh Kamboju wrote: > Following build errors have been noticed. > > fs/tracefs/event_inode.c:348:1: error: return type defaults to 'int' > [-Werror=implicit-int] > 348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei, > | ^~~~~~~~~~~~~~~~~ > In file included from include/uapi/linux/posix_types.h:5, > from include/uapi/linux/types.h:14, > from include/linux/types.h:6, > from include/linux/kasan-checks.h:5, > from include/asm-generic/rwonce.h:26, > from ./arch/x86/include/generated/asm/rwonce.h:1, This patch passed all my tests, I have no idea how the above happened. The "return type defaults to int" tells me the "static struct dentry *" part of the patch may have been clipped. Are you sure it was applied correctly? Perhaps check out the branch I have and let me know if you get the same errors. git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace/core -- Steve