From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C76EC4167B for ; Sun, 29 Oct 2023 23:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbjJ2XSk (ORCPT ); Sun, 29 Oct 2023 19:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbjJ2XSX (ORCPT ); Sun, 29 Oct 2023 19:18:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2794919155; Sun, 29 Oct 2023 16:07:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04457C433B9; Sun, 29 Oct 2023 22:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698620364; bh=oDYk3PAqthxQobNCFCETdOG2KpUFwa6d/m3xZ/ez1t0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PFFFiT80pIdMPDPCHKvpmuk9z/4Se5zqSrXZBLNv+7gZtnWoShz5XIyHVbTmODc4e 0GQjzJkcSrkorrgpVKWwZujcT4tHEXyNpKDQaaqhHC9u/Rj2KQXjZK8EqaidUdc+eX Vh2gdxMcWTFSCsyFk+RWLhkzBXAltr9CgKuc9cnzPNRrnDq434AFvWNwTq+MVS1CjF BtBkOYJpKoCW2Zod4w+FZYtZ5J1YnN9y6H48x0FRbD2/DC6zt1bTmggqSR21QUwXIs /wW9JfTyOqe5DKgLxxwWjClHAJKdC921xfDt/YTXDhHGmaqXHzvG9NBMaQFqe4pGb6 R95GAaMWvtoCg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Konstantin Komarov , syzbot+e94d98936a0ed08bde43@syzkaller.appspotmail.com, Sasha Levin , ntfs3@lists.linux.dev Subject: [PATCH AUTOSEL 5.15 05/28] fs/ntfs3: fix deadlock in mark_as_free_ex Date: Sun, 29 Oct 2023 18:58:40 -0400 Message-ID: <20231029225916.791798-5-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231029225916.791798-1-sashal@kernel.org> References: <20231029225916.791798-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.137 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Komarov [ Upstream commit bfbe5b31caa74ab97f1784fe9ade5f45e0d3de91 ] Reported-by: syzbot+e94d98936a0ed08bde43@syzkaller.appspotmail.com Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/fsntfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c index e32a678861ffe..4413f6da68e60 100644 --- a/fs/ntfs3/fsntfs.c +++ b/fs/ntfs3/fsntfs.c @@ -2451,10 +2451,12 @@ void mark_as_free_ex(struct ntfs_sb_info *sbi, CLST lcn, CLST len, bool trim) { CLST end, i; struct wnd_bitmap *wnd = &sbi->used.bitmap; + bool dirty = false; down_write_nested(&wnd->rw_lock, BITMAP_MUTEX_CLUSTERS); if (!wnd_is_used(wnd, lcn, len)) { - ntfs_set_state(sbi, NTFS_DIRTY_ERROR); + /* mark volume as dirty out of wnd->rw_lock */ + dirty = true; end = lcn + len; len = 0; @@ -2486,6 +2488,8 @@ void mark_as_free_ex(struct ntfs_sb_info *sbi, CLST lcn, CLST len, bool trim) out: up_write(&wnd->rw_lock); + if (dirty) + ntfs_set_state(sbi, NTFS_DIRTY_ERROR); } /* -- 2.42.0