From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5714BC4167B for ; Sun, 29 Oct 2023 23:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232040AbjJ2XcQ (ORCPT ); Sun, 29 Oct 2023 19:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232645AbjJ2Xb6 (ORCPT ); Sun, 29 Oct 2023 19:31:58 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67FEF10CE; Sun, 29 Oct 2023 16:23:31 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3499383F; Mon, 30 Oct 2023 00:23:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698621794; bh=b7fAlWnVHD8ub32pUv2JqeBryzHEQYH8d55fVsFUfVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SKXSwHTavIpNoVy44Yhm+xz0ENUYRR9sRRNfaMB9/XEkKTzqAJeRoUAw0UvuTGZH8 11zwt9Rk+KOoHEegp0bMgiV3oygn7HTScqjMD+OCBqddojgX6rM/bEeMvU2zPNdIWa ose3b9FpRIX/bFPLgYojCnWIwV19gayyS2ccwdt8= Date: Mon, 30 Oct 2023 01:23:35 +0200 From: Laurent Pinchart To: Nancy Nyambura Cc: gagallo7+outreachy@gmail.com, nicydaniels@gmail.com, outreachy@lists.linux.dev, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Media: omap4iss: Enable RSZB and update resizer control Message-ID: <20231029232335.GG12144@pendragon.ideasonboard.com> References: <20231029220710.47063-1-nicymimz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231029220710.47063-1-nicymimz@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Nancy, On Mon, Oct 30, 2023 at 01:07:09AM +0300, Nancy Nyambura wrote: > Enable RSZB functionality in the OMAP4 ISS driver. This change sets the RSZB system configuration register to enable the RSZB module. Additionally, it updates the resizer control by setting the RSZ_EN_EN flag as required. This change enhances the driver's capabilities and prepares it for future developments. You haven't run this through checkpatch, have you ? > Signed-off-by: Nancy Nyambura > --- > drivers/staging/media/omap4iss/iss_resizer.c | 34 +++++++++++--------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/iss_resizer.c b/drivers/staging/media/omap4iss/iss_resizer.c > index a5f8f9f1ab16..23089eeaf448 100644 > --- a/drivers/staging/media/omap4iss/iss_resizer.c > +++ b/drivers/staging/media/omap4iss/iss_resizer.c > @@ -7,17 +7,17 @@ > * Author: Sergio Aguirre > */ > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -#include "iss.h" > -#include "iss_regs.h" > -#include "iss_resizer.h" > + #include > + #include > + #include > + #include > + #include > + #include > + #include > + > + #include "iss.h" > + #include "iss_regs.h" > + #include "iss_resizer.h" Or even read the patch before sending it out ? > > static const unsigned int resizer_fmts[] = { > MEDIA_BUS_FMT_UYVY8_1X16, > @@ -30,11 +30,11 @@ static const unsigned int resizer_fmts[] = { > * > * Also prints other debug information stored in the RESIZER module. > */ > -#define RSZ_PRINT_REGISTER(iss, name)\ > + #define RSZ_PRINT_REGISTER(iss, name)\ > dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", \ > iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name)) > > -#define RZA_PRINT_REGISTER(iss, name)\ > + #define RZA_PRINT_REGISTER(iss, name)\ > dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", \ > iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name)) > > @@ -116,8 +116,12 @@ static void resizer_enable(struct iss_resizer_device *resizer, u8 enable) > RSZ_SRC_EN_SRC_EN, enable ? RSZ_SRC_EN_SRC_EN : 0); > > /* TODO: Enable RSZB */ > - iss_reg_update(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_EN, RSZ_EN_EN, > - enable ? RSZ_EN_EN : 0); > + u32 reg_value = ioread32(iss->base_addr + OMAP4_ISS_MEM_ISP_RESIZER, > + + RZ_SYSCONFIG); > + reg_value |= RSZ_SYSCONFIG_RSZB_CLK_EN; > + iowrite32(reg_value, iss->base_addr + OMAP4_ISS_MEM_ISP_RESIZER, > + + RSZ_SYSCONFIG); > + This doesn't even compile. Has this all been generated by chatgpt by any chance ? It doesn't look like whoever wrote this understand what they were doing. > } > > /* ----------------------------------------------------------------------------- -- Regards, Laurent Pinchart