From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0085EC4332F for ; Mon, 30 Oct 2023 13:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232929AbjJ3N7Y (ORCPT ); Mon, 30 Oct 2023 09:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232118AbjJ3N7X (ORCPT ); Mon, 30 Oct 2023 09:59:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1900EC0 for ; Mon, 30 Oct 2023 06:59:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25ACFC433C8; Mon, 30 Oct 2023 13:59:20 +0000 (UTC) Date: Mon, 30 Oct 2023 09:59:18 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux trace kernel , Andrii Nakryiko , Francis Laniel Subject: Re: [PATCH for-next] tracing/kprobes: Add symbol counting check when module loads Message-ID: <20231030095918.4ec74c88@gandalf.local.home> In-Reply-To: <169854904604.132316.12500381416261460174.stgit@devnote2> References: <169854904604.132316.12500381416261460174.stgit@devnote2> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Oct 2023 12:10:46 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Check the number of probe target symbols in the target module when > the module is loaded. If the probe is not on the unique name symbols > in the module, it will be rejected at that point. > > Note that the symbol which has a unique name in the target module, > it will be accepted even if there are same-name symbols in the > kernel or other modules, > > Signed-off-by: Masami Hiramatsu (Google) > --- > kernel/trace/trace_kprobe.c | 112 ++++++++++++++++++++++++++----------------- > 1 file changed, 68 insertions(+), 44 deletions(-) Reviewed-by: Steven Rosted (Google) -- Steve