From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BBBC4332F for ; Mon, 30 Oct 2023 14:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233529AbjJ3Owa (ORCPT ); Mon, 30 Oct 2023 10:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbjJ3Ow2 (ORCPT ); Mon, 30 Oct 2023 10:52:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D639CC; Mon, 30 Oct 2023 07:52:23 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 321FD6732A; Mon, 30 Oct 2023 15:52:20 +0100 (CET) Date: Mon, 30 Oct 2023 15:52:20 +0100 From: Christoph Hellwig To: Christophe JAILLET Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2] nvme-tcp: Fix a memory leak Message-ID: <20231030145220.GA28484@lst.de> References: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig > Personally I prefer v1. Pick the one you prefer :) I think we should be consistent with one style or another in a given function. Otherwise I wouldn't even have mentioned it.