From: Sumit Garg <sumit.garg@linaro.org>
To: jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org
Cc: jan.kiszka@siemens.com, arnd@linaro.org, ardb@kernel.org,
jerome.forissier@linaro.org, ilias.apalodimas@linaro.org,
masahisa.kojima@linaro.org, maxim.uvarov@linaro.org,
jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org,
diogo.ivo@siemens.com, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v3 0/2] tee: optee: Fixes for supplicant dependent enumeration
Date: Mon, 30 Oct 2023 21:28:59 +0530 [thread overview]
Message-ID: <20231030155901.80673-1-sumit.garg@linaro.org> (raw)
Currently supplicant dependent optee device enumeration only registers
devices whenever tee-supplicant is invoked for the first time. But it
forgets to remove devices when tee-supplicant daemon stops running and
closes its context gracefully. This leads to following error for fTPM
driver during reboot/shutdown:
[ 73.466791] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff3024
Fix this by separating supplicant dependent devices so that the
user-space service can detach supplicant devices before closing the
supplicant. While at it use the global system workqueue for OP-TEE bus
scanning work rather than our own custom one.
Changes in v3:
- Split patch into 2 separate ones, one for supplicant fix and other for
the workqueue.
Changes in v2:
- Use device names to separate out tee-supplicant dependent devices via
this patch.
- Since user-space service is aware about tee-supplicant lifespan, so
allow the user-space service to unbind tee-supplicant dependent
devices before killing the supplicant. Following command has to be
added to the tee-supplicant service file.
$ for dev in /sys/bus/tee/devices/*; do if [[ "$dev" == *"optee-ta-supp-"* ]]; \
then echo $(basename "$dev") > $dev/driver/unbind; fi done
Sumit Garg (2):
tee: optee: Fix supplicant based device enumeration
tee: optee: Remove redundant custom workqueue
drivers/tee/optee/core.c | 13 ++-----------
drivers/tee/optee/device.c | 13 ++++++++++---
drivers/tee/optee/optee_private.h | 2 --
3 files changed, 12 insertions(+), 16 deletions(-)
--
2.34.1
next reply other threads:[~2023-10-30 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 15:58 Sumit Garg [this message]
2023-10-30 15:59 ` [PATCH v3 1/2] tee: optee: Fix supplicant based device enumeration Sumit Garg
2023-10-31 11:04 ` Jerome Forissier
2023-10-31 11:44 ` Jan Kiszka
2023-11-02 7:37 ` Sumit Garg
2023-11-02 7:58 ` Jan Kiszka
2023-11-02 8:02 ` Sumit Garg
2023-11-02 8:05 ` Jan Kiszka
2023-11-02 8:09 ` Sumit Garg
2023-10-30 15:59 ` [PATCH v3 2/2] tee: optee: Remove redundant custom workqueue Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030155901.80673-1-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=ardb@kernel.org \
--cc=arnd@linaro.org \
--cc=diogo.ivo@siemens.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jens.wiklander@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=maxim.uvarov@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®